Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if_perl.xs: Suppress Infinite warnings when compiling XS modules under macOS 12 #11499

Closed
wants to merge 1 commit into from
Closed

Conversation

pheiduck
Copy link
Contributor

@pheiduck pheiduck commented Nov 4, 2022

Maybe the defined(__clang__) is not needed?

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #11499 (068c50c) into master (c57b5bc) will decrease coverage by 3.74%.
The diff coverage is n/a.

❗ Current head 068c50c differs from pull request most recent head 30a3aff. Consider uploading reports for the commit 30a3aff to get more accurate results

@@            Coverage Diff             @@
##           master   #11499      +/-   ##
==========================================
- Coverage   81.82%   78.07%   -3.75%     
==========================================
  Files         162      148      -14     
  Lines      189752   147533   -42219     
  Branches    43137    38237    -4900     
==========================================
- Hits       155261   115193   -40068     
+ Misses      21925    20378    -1547     
+ Partials    12566    11962     -604     
Flag Coverage Δ
huge-clang-none ?
huge-gcc-none ?
huge-gcc-testgui ?
huge-gcc-unittests ?
linux ?
mingw-x64-HUGE 76.43% <ø> (+<0.01%) ⬆️
mingw-x86-HUGE 77.28% <ø> (+0.01%) ⬆️
windows 78.07% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/xdiff/xpatience.c 0.00% <0.00%> (-81.99%) ⬇️
src/xdiff/xhistogram.c 0.00% <0.00%> (-73.72%) ⬇️
src/hardcopy.c 10.87% <0.00%> (-66.18%) ⬇️
src/if_cscope.c 4.89% <0.00%> (-63.74%) ⬇️
src/beval.c 12.00% <0.00%> (-51.64%) ⬇️
src/libvterm/src/mouse.c 0.00% <0.00%> (-45.17%) ⬇️
src/debugger.c 50.60% <0.00%> (-41.71%) ⬇️
src/sound.c 27.65% <0.00%> (-39.01%) ⬇️
src/mouse.c 50.59% <0.00%> (-28.97%) ⬇️
src/libvterm/src/keyboard.c 15.78% <0.00%> (-25.27%) ⬇️
... and 143 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pheiduck
Copy link
Contributor Author

pheiduck commented Nov 4, 2022

hm, shows other errors we had seen before perl downgrade any hints to solve this error?

2022-11-04T11:46:32.1559020Z In file included from if_perl.xs:62:
2022-11-04T11:46:32.1560690Z In file included from /usr/local/opt/perl/lib/perl5/5.36/darwin-thread-multi-2level/CORE/perl.h:7243:
2022-11-04T11:46:32.1561840Z /usr/local/opt/perl/lib/perl5/5.36/darwin-thread-multi-2level/CORE/sv_inline.h:487:40: error: declaration shadows a local variable [-Werror,-Wshadow]
2022-11-04T11:46:32.1562620Z             SvSTASH_set(io, MUTABLE_HV(SvREFCNT_inc(GvHV(iogv))));
2022-11-04T11:46:32.1563180Z                                        ^
2022-11-04T11:46:32.1564100Z /usr/local/opt/perl/lib/perl5/5.36/darwin-thread-multi-2level/CORE/sv.h:346:45: note: expanded from macro 'SvREFCNT_inc'
2022-11-04T11:46:32.1568580Z #define SvREFCNT_inc(sv)                Perl_SvREFCNT_inc(MUTABLE_SV(sv))
2022-11-04T11:46:32.1569240Z                                                           ^
2022-11-04T11:46:32.1570440Z /usr/local/opt/perl/lib/perl5/5.36/darwin-thread-multi-2level/CORE/handy.h:107:30: note: expanded from macro 'MUTABLE_SV'
2022-11-04T11:46:32.1570870Z #define MUTABLE_SV(p)   ((SV *)MUTABLE_PTR(p))
2022-11-04T11:46:32.1571090Z                                ^
2022-11-04T11:46:32.1571610Z /usr/local/opt/perl/lib/perl5/5.36/darwin-thread-multi-2level/CORE/handy.h:97:35: note: expanded from macro 'MUTABLE_PTR'
2022-11-04T11:46:32.1571960Z #  define MUTABLE_PTR(p) ({ void *p_ = (p); p_; })
2022-11-04T11:46:32.1572190Z                                   ^
2022-11-04T11:46:32.1572680Z /usr/local/opt/perl/lib/perl5/5.36/darwin-thread-multi-2level/CORE/sv_inline.h:487:29: note: previous declaration is here
2022-11-04T11:46:32.1573030Z             SvSTASH_set(io, MUTABLE_HV(SvREFCNT_inc(GvHV(iogv))));
2022-11-04T11:46:32.1573270Z                             ^
2022-11-04T11:46:32.1573740Z /usr/local/opt/perl/lib/perl5/5.36/darwin-thread-multi-2level/CORE/handy.h:105:30: note: expanded from macro 'MUTABLE_HV'
2022-11-04T11:46:32.1574100Z #define MUTABLE_HV(p)   ((HV *)MUTABLE_PTR(p))
2022-11-04T11:46:32.1575210Z                                ^
2022-11-04T11:46:32.1575800Z /usr/local/opt/perl/lib/perl5/5.36/darwin-thread-multi-2level/CORE/handy.h:97:35: note: expanded from macro 'MUTABLE_PTR'
2022-11-04T11:46:32.1576170Z #  define MUTABLE_PTR(p) ({ void *p_ = (p); p_; })
2022-11-04T11:46:32.1576820Z                                   ^
2022-11-04T11:46:32.5981380Z 1 error generated.
2022-11-04T11:46:32.6034790Z make[1]: *** [objects/if_perl.o] Error 1
2022-11-04T11:46:32.6039550Z make: *** [first] Error 2
2022-11-04T11:46:32.6078590Z ##[error]Process completed with exit code 2.

@pheiduck pheiduck marked this pull request as draft November 4, 2022 12:06
@pheiduck pheiduck marked this pull request as ready for review November 4, 2022 12:06
@pheiduck
Copy link
Contributor Author

pheiduck commented Nov 4, 2022

Will revert the last 2 commits later

@pheiduck
Copy link
Contributor Author

pheiduck commented Nov 4, 2022

hm, shows other errors we had seen before perl downgrade any hints to solve this error?

2022-11-04T11:46:32.1559020Z In file included from if_perl.xs:62:
2022-11-04T11:46:32.1560690Z In file included from /usr/local/opt/perl/lib/perl5/5.36/darwin-thread-multi-2level/CORE/perl.h:7243:
2022-11-04T11:46:32.1561840Z /usr/local/opt/perl/lib/perl5/5.36/darwin-thread-multi-2level/CORE/sv_inline.h:487:40: error: declaration shadows a local variable [-Werror,-Wshadow]
2022-11-04T11:46:32.1562620Z             SvSTASH_set(io, MUTABLE_HV(SvREFCNT_inc(GvHV(iogv))));
2022-11-04T11:46:32.1563180Z                                        ^
2022-11-04T11:46:32.1564100Z /usr/local/opt/perl/lib/perl5/5.36/darwin-thread-multi-2level/CORE/sv.h:346:45: note: expanded from macro 'SvREFCNT_inc'
2022-11-04T11:46:32.1568580Z #define SvREFCNT_inc(sv)                Perl_SvREFCNT_inc(MUTABLE_SV(sv))
2022-11-04T11:46:32.1569240Z                                                           ^
2022-11-04T11:46:32.1570440Z /usr/local/opt/perl/lib/perl5/5.36/darwin-thread-multi-2level/CORE/handy.h:107:30: note: expanded from macro 'MUTABLE_SV'
2022-11-04T11:46:32.1570870Z #define MUTABLE_SV(p)   ((SV *)MUTABLE_PTR(p))
2022-11-04T11:46:32.1571090Z                                ^
2022-11-04T11:46:32.1571610Z /usr/local/opt/perl/lib/perl5/5.36/darwin-thread-multi-2level/CORE/handy.h:97:35: note: expanded from macro 'MUTABLE_PTR'
2022-11-04T11:46:32.1571960Z #  define MUTABLE_PTR(p) ({ void *p_ = (p); p_; })
2022-11-04T11:46:32.1572190Z                                   ^
2022-11-04T11:46:32.1572680Z /usr/local/opt/perl/lib/perl5/5.36/darwin-thread-multi-2level/CORE/sv_inline.h:487:29: note: previous declaration is here
2022-11-04T11:46:32.1573030Z             SvSTASH_set(io, MUTABLE_HV(SvREFCNT_inc(GvHV(iogv))));
2022-11-04T11:46:32.1573270Z                             ^
2022-11-04T11:46:32.1573740Z /usr/local/opt/perl/lib/perl5/5.36/darwin-thread-multi-2level/CORE/handy.h:105:30: note: expanded from macro 'MUTABLE_HV'
2022-11-04T11:46:32.1574100Z #define MUTABLE_HV(p)   ((HV *)MUTABLE_PTR(p))
2022-11-04T11:46:32.1575210Z                                ^
2022-11-04T11:46:32.1575800Z /usr/local/opt/perl/lib/perl5/5.36/darwin-thread-multi-2level/CORE/handy.h:97:35: note: expanded from macro 'MUTABLE_PTR'
2022-11-04T11:46:32.1576170Z #  define MUTABLE_PTR(p) ({ void *p_ = (p); p_; })
2022-11-04T11:46:32.1576820Z                                   ^
2022-11-04T11:46:32.5981380Z 1 error generated.
2022-11-04T11:46:32.6034790Z make[1]: *** [objects/if_perl.o] Error 1
2022-11-04T11:46:32.6039550Z make: *** [first] Error 2
2022-11-04T11:46:32.6078590Z ##[error]Process completed with exit code 2.

Maybe a think for next PR

@pheiduck
Copy link
Contributor Author

pheiduck commented Nov 4, 2022

The python errors will be fixed w/ #11484

@brammool brammool closed this in 5375205 Nov 4, 2022
@pheiduck pheiduck deleted the fixup/perl branch November 4, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants