Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: ACCESS_* enum naming conflicts on some systems. #12105

Closed
wants to merge 1 commit into from

Conversation

sodero
Copy link
Contributor

@sodero sodero commented Mar 4, 2023

Solution: Add VIM_ prefix to avoid conflicts.

Solution: Add VIM_ prefix to avoid conflicts.
@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #12105 (111a974) into master (c99cbf8) will decrease coverage by 0.59%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #12105      +/-   ##
==========================================
- Coverage   81.91%   81.32%   -0.59%     
==========================================
  Files         164      164              
  Lines      194073   194043      -30     
  Branches    43863    43857       -6     
==========================================
- Hits       158983   157814    -1169     
- Misses      22252    23508    +1256     
+ Partials    12838    12721     -117     
Flag Coverage Δ
huge-clang-none 82.64% <100.00%> (+<0.01%) ⬆️
huge-gcc-none 53.22% <60.00%> (-0.03%) ⬇️
huge-gcc-testgui 51.35% <60.00%> (-0.03%) ⬇️
huge-gcc-unittests 0.29% <0.00%> (-0.01%) ⬇️
linux 82.35% <100.00%> (+0.01%) ⬆️
mingw-x64-HUGE 76.52% <100.00%> (+<0.01%) ⬆️
mingw-x86-HUGE ?
windows 76.52% <100.00%> (-1.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/fileio.c 76.01% <ø> (ø)
src/eval.c 92.12% <100.00%> (ø)
src/vim9class.c 81.78% <100.00%> (ø)
src/vimrun.c 0.00% <0.00%> (-50.00%) ⬇️
src/gui_dwrite.cpp 1.19% <0.00%> (-44.74%) ⬇️
src/xpm_w32.c 0.00% <0.00%> (-38.47%) ⬇️
src/gui_w32.c 23.49% <0.00%> (-16.36%) ⬇️
src/os_mswin.c 40.93% <0.00%> (-8.53%) ⬇️
src/os_win32.c 61.51% <0.00%> (-5.72%) ⬇️
src/winclip.c 58.19% <0.00%> (-4.51%) ⬇️
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@brammool brammool closed this in d874247 Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant