Improve .fs filetype detection #12219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces false Forth negatives to about 5%, while keeping the number of false F# positives very low. Closes vim#11988
Codecov Report
@@ Coverage Diff @@
## master #12219 +/- ##
===========================================
- Coverage 81.94% 0.29% -81.65%
===========================================
Files 164 154 -10
Lines 194111 179293 -14818
Branches 43831 40970 -2861
===========================================
- Hits 159055 522 -158533
- Misses 22216 178714 +156498
+ Partials 12840 57 -12783
Flags with carried forward coverage won't be shown. Click here to find out more. see 158 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
clason
added a commit
to clason/neovim
that referenced
this pull request
Apr 3, 2023
Problem: .fs files are falsely recognized as forth files.
Solution: Check 100 lines for something that looks like forth. (Johan
Kotlinski, closes vim/vim#12219, closes vim/vim#11988)
vim/vim@065088d
Co-authored-by: Johan Kotlinski <kotlinski@gmail.com>
clason
added a commit
to clason/neovim
that referenced
this pull request
Apr 3, 2023
Problem: .fs files are falsely recognized as forth files.
Solution: Check 100 lines for something that looks like forth. (Johan
Kotlinski, closes vim/vim#12219, closes vim/vim#11988)
vim/vim@065088d
Co-authored-by: Johan Kotlinski <kotlinski@gmail.com>
clason
added a commit
to clason/neovim
that referenced
this pull request
Apr 3, 2023
Problem: .fs files are falsely recognized as forth files.
Solution: Check 100 lines for something that looks like forth. (Johan
Kotlinski, closes vim/vim#12219, closes vim/vim#11988)
vim/vim@065088d
Co-authored-by: Johan Kotlinski <kotlinski@gmail.com>
clason
added a commit
to clason/neovim
that referenced
this pull request
Apr 3, 2023
Problem: .fs files are falsely recognized as forth files.
Solution: Check 100 lines for something that looks like forth. (Johan
Kotlinski, closes vim/vim#12219, closes vim/vim#11988)
vim/vim@065088d
Co-authored-by: Johan Kotlinski <kotlinski@gmail.com>
clason
added a commit
to neovim/neovim
that referenced
this pull request
Apr 3, 2023
…22871) Problem: .fs files are falsely recognized as forth files. Solution: Check 100 lines for something that looks like forth. (Johan Kotlinski, closes vim/vim#12219, closes vim/vim#11988) vim/vim@065088d Co-authored-by: Johan Kotlinski <kotlinski@gmail.com>
theHamsta
pushed a commit
to theHamsta/neovim
that referenced
this pull request
Apr 7, 2023
…eovim#22871) Problem: .fs files are falsely recognized as forth files. Solution: Check 100 lines for something that looks like forth. (Johan Kotlinski, closes vim/vim#12219, closes vim/vim#11988) vim/vim@065088d Co-authored-by: Johan Kotlinski <kotlinski@gmail.com>
Xevnar
added a commit
to Xevnar/filetype.nvim
that referenced
this pull request
Apr 8, 2023
…m#22871) Problem: .fs files are falsely recognized as forth files. Solution: Check 100 lines for something that looks like forth. (Johan Kotlinski, closes vim/vim#12219, closes vim/vim#11988) vim/vim@065088d https://github.com/neovim/neovim/commit Co-authored-by: Johan Kotlinski <kotlinski@gmail.com>
folke
pushed a commit
to folke/neovim
that referenced
this pull request
May 22, 2023
…eovim#22871) Problem: .fs files are falsely recognized as forth files. Solution: Check 100 lines for something that looks like forth. (Johan Kotlinski, closes vim/vim#12219, closes vim/vim#11988) vim/vim@065088d Co-authored-by: Johan Kotlinski <kotlinski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces false Forth negatives to about 5%, while keeping the number of false Forth positives very low. Closes #11988