Reduce unnecessary calls to STRLEN() in ex_spellrepall() #12497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix typo in test name.
Codecov Report
@@ Coverage Diff @@
## master #12497 +/- ##
==========================================
+ Coverage 77.08% 82.09% +5.00%
==========================================
Files 150 160 +10
Lines 151227 193606 +42379
Branches 38964 43469 +4505
==========================================
+ Hits 116574 158938 +42364
+ Misses 22482 21823 -659
- Partials 12171 12845 +674
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Jun 6, 2023
Problem: strlen() called too often for :spellrepall. Solution: Store the result in a variable. (closes vim/vim#12497) vim/vim@59f7038
zeertzjq
added a commit
to neovim/neovim
that referenced
this pull request
Jun 6, 2023
Problem: strlen() called too often for :spellrepall. Solution: Store the result in a variable. (closes vim/vim#12497) vim/vim@59f7038
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix typo in test name.