runtime(vim): Improve :let-heredoc syntax highlighting #12923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12923 +/- ##
==========================================
- Coverage 82.20% 82.04% -0.17%
==========================================
Files 160 160
Lines 196942 194679 -2263
Branches 44128 43696 -432
==========================================
- Hits 161893 159719 -2174
+ Misses 22138 22087 -51
+ Partials 12911 12873 -38
Flags with carried forward coverage won't be shown. Click here to find out more. |
dkearns
force-pushed
the
runtime-vim-improve-letheredoc-highlighting
branch
from
2aba0ec
to
da55133
Compare
|
@cecamp please |
"trim" and "eval" are allowed in any order and whitespace is not required after "=<<".
dkearns
force-pushed
the
runtime-vim-improve-letheredoc-highlighting
branch
from
da55133
to
dbef1e3
Compare
|
I think this can be included @chrisbra, it's an isolated change. |
|
thanks, makse sense to include |
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Nov 11, 2023
runtime(vim): Improve :let-heredoc syntax highlighting (vim/vim#12923) "trim" and "eval" are allowed in any order and whitespace is not required after "=<<". vim/vim@9358b8d Co-authored-by: dkearns <dougkearns@gmail.com>
zeertzjq
added a commit
to neovim/neovim
that referenced
this pull request
Nov 12, 2023
runtime(vim): Improve :let-heredoc syntax highlighting (vim/vim#12923) "trim" and "eval" are allowed in any order and whitespace is not required after "=<<". vim/vim@9358b8d Co-authored-by: dkearns <dougkearns@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"trim" and "eval" are allowed in any order.
@cecamp, I sent this to you about a year ago but didn't receive a reply. This is unusual so I'm submitting the change here as well in case my email has dissipated in the ether.