Fix "Open &Tab..." CJK translations to have shortcut key #13031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous PR (vim#12993) fixed localization files to point to "Open &Tab..." but they didn't add the shortcut key to the translated names. This adds the shortcut keys to the CJK translations in the form of "(&T)". Note that this doesn't add the shortcut to latin script languages like Czech. These types of translated names tend to also localize the shortcut keys for them to make sense to the user and it's up to each translator to decide how to do so. CJK translations tend to just take the English key directly since it doesn't make sense to have a localized shortcut key in general.
Codecov Report
@@ Coverage Diff @@
## master #13031 +/- ##
==========================================
- Coverage 82.08% 82.08% -0.01%
==========================================
Files 160 160
Lines 194941 194941
Branches 43753 43753
==========================================
- Hits 160011 160008 -3
Misses 22070 22070
- Partials 12860 12863 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
For the Japanese translations, I'm now preparing them in the translation repository: |
|
thanks! |
chrisbra
pushed a commit
to chrisbra/vim
that referenced
this pull request
Sep 22, 2023
…ey (vim#13031) Previous PR (vim#12993) fixed localization files to point to "Open &Tab..." but they didn't add the shortcut key to the translated names. This adds the shortcut keys to the CJK translations in the form of "(&T)". Note that this doesn't add the shortcut to latin script languages like Czech. These types of translated names tend to also localize the shortcut keys for them to make sense to the user and it's up to each translator to decide how to do so. CJK translations tend to just take the English key directly since it doesn't make sense to have a localized shortcut key in general. Signed-off-by: Christian Brabandt <cb@256bit.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR (#12993) fixed localization files to point to "Open &Tab..." but they didn't add the shortcut key to the translated names. This adds the shortcut keys to the CJK translations in the form of "(&T)".
Note that this doesn't add the shortcut to latin script languages like Czech. These types of translated names tend to also localize the shortcut keys for them to make sense to the user and it's up to each translator to decide how to do so. CJK translations tend to just take the English key directly since it doesn't make sense to have a localized shortcut key in general.