Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linebreak should not apply for leading whitespace #13243

Closed
wants to merge 1 commit into from

Conversation

chrisbra
Copy link
Member

@chrisbra chrisbra commented Oct 1, 2023

linebreak should only apply after first non-whitespce

closes: #13228

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #13243 (9f7236f) into master (f4ee1cb) will decrease coverage by 0.03%.
Report is 3 commits behind head on master.
The diff coverage is 92.30%.

❗ Current head 9f7236f differs from pull request most recent head 0df9ce2. Consider uploading reports for the commit 0df9ce2 to get more accurate results

@@            Coverage Diff             @@
##           master   #13243      +/-   ##
==========================================
- Coverage   82.20%   82.17%   -0.03%     
==========================================
  Files         160      160              
  Lines      196358   196207     -151     
  Branches    44002    43963      -39     
==========================================
- Hits       161411   161241     -170     
- Misses      22072    22103      +31     
+ Partials    12875    12863      -12     
Flag Coverage Δ
huge-clang-Array 82.82% <84.61%> (-0.03%) ⬇️
linux 82.82% <84.61%> (-0.03%) ⬇️
mingw-x64-HUGE 76.78% <91.66%> (+0.01%) ⬆️
mingw-x86-HUGE 77.29% <91.66%> (-0.03%) ⬇️
windows 78.37% <91.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/drawline.c 84.59% <100.00%> (+0.03%) ⬆️
src/charset.c 85.97% <85.71%> (-0.02%) ⬇️

... and 33 files with indirect coverage changes

@chrisbra chrisbra force-pushed the gh-13228 branch 2 times, most recently from 44d22d8 to 9f7236f Compare October 4, 2023 18:15
gh-issue 13228, linebreak only applies after first non-whitespce
@chrisbra chrisbra closed this in dd75fcf Oct 11, 2023
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Oct 11, 2023
Problem:  linebreak applies for leading whitespace
Solution: only apply linebreak, once we have found non-breakat chars in
          the line

closes: vim/vim#13228
closes: vim/vim#13243

vim/vim@dd75fcf

Co-authored-by: Christian Brabandt <cb@256bit.org>
zeertzjq added a commit to neovim/neovim that referenced this pull request Oct 11, 2023
Problem:  linebreak applies for leading whitespace
Solution: only apply linebreak, once we have found non-breakat chars in
          the line

closes: vim/vim#13228
closes: vim/vim#13243

vim/vim@dd75fcf

Co-authored-by: Christian Brabandt <cb@256bit.org>
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Oct 11, 2023
Problem:  linebreak applies for leading whitespace
Solution: only apply linebreak, once we have found non-breakat chars in
          the line

closes: vim/vim#13228
closes: vim/vim#13243

vim/vim@dd75fcf

Co-authored-by: Christian Brabandt <cb@256bit.org>
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Oct 11, 2023
Problem:  linebreak applies for leading whitespace
Solution: only apply linebreak, once we have found non-breakat chars in
          the line

closes: vim/vim#13228
closes: vim/vim#13243

vim/vim@dd75fcf

Co-authored-by: Christian Brabandt <cb@256bit.org>
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Oct 11, 2023
Problem:  linebreak applies for leading whitespace
Solution: only apply linebreak, once we have found non-breakat chars in
          the line

closes: vim/vim#13228
closes: vim/vim#13243

vim/vim@dd75fcf

Co-authored-by: Christian Brabandt <cb@256bit.org>
jaehoonhwang pushed a commit to jaehoonhwang/neovim that referenced this pull request Oct 22, 2023
Problem:  linebreak applies for leading whitespace
Solution: only apply linebreak, once we have found non-breakat chars in
          the line

closes: vim/vim#13228
closes: vim/vim#13243

vim/vim@dd75fcf

Co-authored-by: Christian Brabandt <cb@256bit.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra line break visible after indent when settings wrap, linebreak and breakindent are enabled
1 participant