Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two unrelated things are tested by a single test #14323

Closed
wants to merge 1 commit into from

Conversation

zeertzjq
Copy link
Member

@zeertzjq zeertzjq commented Mar 28, 2024

Problem: Two unrelated things are tested by a single test.
Solution: Split it into two, restoring the old Test_brace_single_line().
Add missing cleanup to some tests.

@zeertzjq zeertzjq force-pushed the test-brace branch 7 times, most recently from fc09858 to b944610 Compare March 28, 2024 12:58
@zeertzjq
Copy link
Member Author

zeertzjq commented Mar 28, 2024

I also don't think 'smoothscroll' should be referred to as "partly implemented" now, as it now covers all applicable scrolling commands listed in :h scroll-down and :h scroll-up. It isn't applicable to z+ and z^ as they move the cursor to the first non-blank of a line.

@luukvbaal
Copy link
Contributor

luukvbaal commented Mar 28, 2024

It still works poorly with gj and gk, or cursor movement in general. I think there is an open issue/todo.txt item for that. update_topline() needs to allow for the cursor to be in a not fully visible botline/topline.

@luukvbaal
Copy link
Contributor

luukvbaal commented Mar 28, 2024

Hmm no open issue, but I think it was added to the todo list after #12411 (comment). So I think it should still be referred to as "partly implemented", but perhaps the implemented list in options.txt could be inverted to a not-implemented list.

Problem:  Two unrelated things are tested by a single test.
Solution: Split it into two, restoring the old Test_brace_single_line().
          Add missing cleanup to some tests.
@chrisbra
Copy link
Member

Thanks, makes sense.

@chrisbra chrisbra closed this in ad493ef Mar 29, 2024
@zeertzjq zeertzjq deleted the test-brace branch March 29, 2024 09:27
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Mar 29, 2024
Problem:  Two unrelated things are tested by a single test.
Solution: Split it into two, restoring the old Test_brace_single_line().
          Add missing cleanup to some tests.
          (zeertzjq)

closes: vim/vim#14323

vim/vim@ad493ef
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Mar 29, 2024
Problem:  Two unrelated things are tested by a single test.
Solution: Split it into two, restoring the old Test_brace_single_line().
          Add missing cleanup to some tests.
          (zeertzjq)

closes: vim/vim#14323

vim/vim@ad493ef
zeertzjq added a commit to neovim/neovim that referenced this pull request Mar 29, 2024
…28093)

Problem:  Two unrelated things are tested by a single test.
Solution: Split it into two, restoring the old Test_brace_single_line().
          Add missing cleanup to some tests.
          (zeertzjq)

closes: vim/vim#14323

vim/vim@ad493ef
huangyingw pushed a commit to huangyingw/neovim that referenced this pull request May 31, 2024
…eovim#28093)

Problem:  Two unrelated things are tested by a single test.
Solution: Split it into two, restoring the old Test_brace_single_line().
          Add missing cleanup to some tests.
          (zeertzjq)

closes: vim/vim#14323

vim/vim@ad493ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants