fix: Regression setcellwidths with GUI #14600
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression has occurred since version 9.1.0344.
(ID-Call as patch authors: @mikoto2000 @zeertzjq)
Related: #14539 #14540
Step to repro.
Behavior of GUI Vim 9.1.0344
![gui_ng_1](https://private-user-images.githubusercontent.com/518808/324172256-273cefbb-35b9-4877-8534-fa440ff14dae.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MTEyMzMsIm5iZiI6MTcxOTYxMDkzMywicGF0aCI6Ii81MTg4MDgvMzI0MTcyMjU2LTI3M2NlZmJiLTM1YjktNDg3Ny04NTM0LWZhNDQwZmYxNGRhZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyOFQyMTQyMTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03YzAzZmI2Y2EzYjgzZjQ4YzQzOGFhOWM5ODE2NDlkNDA4NWM0ZmNjOGYxMWM0YWYyYzUyNTExNGZlMDFhMzgzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.tM1o754piFAltegJO5iuzSNfbccP2IS1jZze0Wuk_hk)
There is an extra space before
d
.After type
![gui_ng](https://private-user-images.githubusercontent.com/518808/324172670-af78f063-a779-4f3c-b113-82bb5584ff33.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MTEyMzMsIm5iZiI6MTcxOTYxMDkzMywicGF0aCI6Ii81MTg4MDgvMzI0MTcyNjcwLWFmNzhmMDYzLWE3NzktNGYzYy1iMTEzLTgyYmI1NTg0ZmYzMy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyOFQyMTQyMTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00NTYzNzZkM2UxZGIxM2M2YzAzOWRlYWQ5MWRjZjAzMGFiZGJmOGI3ZDI4MWJkNTZmYjZjYmRiOTk4ZmVkMGY1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.TkYW9dch1rVvQhLwyuMEaujHspvU9zwGEHeENevzTy4)
fd
, The cursor will move to the extra space andd
will appear.Expected behavior
Behavior of GUI Vim before version 9.1.0343 or with this PR patch applied.
![gui_ok_1](https://private-user-images.githubusercontent.com/518808/324172722-2c8fb70c-f71a-4120-ae03-7ac00df17f52.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MTEyMzMsIm5iZiI6MTcxOTYxMDkzMywicGF0aCI6Ii81MTg4MDgvMzI0MTcyNzIyLTJjOGZiNzBjLWY3MWEtNDEyMC1hZTAzLTdhYzAwZGYxN2Y1Mi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyOFQyMTQyMTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xMDMwMmZkMmIwNWRlZjAwMGFjZDkyMTVmZDNjN2E1YzI0OWZhMTZmNjJkMjc5OTJhMWFjNTcxZDY4ZDc4NGQwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.cIFiueX4mzF85cjPd_uIUx8ryjhdGzk8WP9H4O861XU)
There is no extra space before d.
After type
![gui_ok](https://private-user-images.githubusercontent.com/518808/324172756-04ddd70e-a223-46e7-9e62-e01f8a7d038e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MTEyMzMsIm5iZiI6MTcxOTYxMDkzMywicGF0aCI6Ii81MTg4MDgvMzI0MTcyNzU2LTA0ZGRkNzBlLWEyMjMtNDZlNy05ZTYyLWUwMWY4YTdkMDM4ZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyOFQyMTQyMTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05ZDFkNzZlNWU4ZWNjOWFkNDZmNmJmNjgyMmM1ZjIyMjk2NjE0MTEzNWI4MDZhNWIzMzczYWVkNWUxOGU2MGViJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.zQ-PD653zFfPWtA95vB5IZMxwB7_RQLZkP-2gJKsUs0)
fd
.