Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count just enough lines for half page scrolling #14652

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/drawscreen.c
Original file line number Diff line number Diff line change
Expand Up @@ -1781,7 +1781,7 @@ win_update(win_T *wp)
if (j < wp->w_height - 2) // not too far off
{
i = plines_m_win(wp, wp->w_topline, wp->w_lines[0].wl_lnum - 1,
TRUE);
wp->w_height);
#ifdef FEAT_DIFF
// insert extra lines for previously invisible filler lines
if (wp->w_lines[0].wl_lnum != wp->w_topline)
Expand Down
13 changes: 8 additions & 5 deletions src/misc1.c
Original file line number Diff line number Diff line change
Expand Up @@ -497,12 +497,17 @@ plines_win_col(win_T *wp, linenr_T lnum, long column)
return lines;
}

/*
* Return number of window lines the physical line range from "first" until
* "last" will occupy in window "wp". Takes into account folding, 'wrap',
* topfill and filler lines beyond the end of the buffer. Limit to "max" lines.
*/
int
plines_m_win(win_T *wp, linenr_T first, linenr_T last, int limit_winheight)
plines_m_win(win_T *wp, linenr_T first, linenr_T last, int max)
{
int count = 0;

while (first <= last && (!limit_winheight || count < wp->w_height))
while (first <= last && count < max)
{
#ifdef FEAT_FOLDING
int x;
Expand Down Expand Up @@ -531,9 +536,7 @@ plines_m_win(win_T *wp, linenr_T first, linenr_T last, int limit_winheight)
if (first == wp->w_buffer->b_ml.ml_line_count + 1)
count += diff_check_fill(wp, first);
#endif
if (limit_winheight && count > wp->w_height)
return wp->w_height;
return (count);
return MIN(max, count);
}

int
Expand Down
14 changes: 10 additions & 4 deletions src/move.c
Original file line number Diff line number Diff line change
Expand Up @@ -1455,7 +1455,7 @@ textpos2screenpos(

is_folded = hasFoldingWin(wp, lnum, &lnum, NULL, TRUE, NULL);
#endif
row = plines_m_win(wp, wp->w_topline, lnum - 1, FALSE);
row = plines_m_win(wp, wp->w_topline, lnum - 1, INT_MAX);
// "row" should be the screen line where line "lnum" begins, which can
// be negative if "lnum" is "w_topline" and "w_skipcol" is non-zero.
row -= adjust_plines_for_skipcol(wp);
Expand Down Expand Up @@ -3219,12 +3219,18 @@ pagescroll(int dir, long count, int half)

int curscount = count;
// Adjust count so as to not reveal end of buffer lines.
if (dir == FORWARD)
if (dir == FORWARD
&& (curwin->w_topline + curwin->w_height + count > buflen
#ifdef FEAT_FOLDING
|| hasAnyFolding(curwin)
#endif
))
{
int n = plines_correct_topline(curwin, curwin->w_topline, FALSE);
if (n - count < curwin->w_height && curwin->w_topline < buflen)
n += plines_m_win(curwin, curwin->w_topline + 1, buflen, FALSE);
if (n - count < curwin->w_height)
n += plines_m_win(curwin, curwin->w_topline + 1, buflen,
curwin->w_height + count);
if (n < curwin->w_height + count)
count = n - curwin->w_height;
}

Expand Down
4 changes: 2 additions & 2 deletions src/popupwin.c
Original file line number Diff line number Diff line change
Expand Up @@ -654,8 +654,8 @@ popup_show_curline(win_T *wp)
wp->w_topline = wp->w_buffer->b_ml.ml_line_count;
while (wp->w_topline < wp->w_cursor.lnum
&& wp->w_topline < wp->w_buffer->b_ml.ml_line_count
&& plines_m_win(wp, wp->w_topline, wp->w_cursor.lnum, FALSE)
> wp->w_height)
&& plines_m_win(wp, wp->w_topline, wp->w_cursor.lnum,
wp->w_height + 1) > wp->w_height)
++wp->w_topline;
}

Expand Down
2 changes: 1 addition & 1 deletion src/proto/misc1.pro
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ int plines_nofill(linenr_T lnum);
int plines_win_nofill(win_T *wp, linenr_T lnum, int limit_winheight);
int plines_win_nofold(win_T *wp, linenr_T lnum);
int plines_win_col(win_T *wp, linenr_T lnum, long column);
int plines_m_win(win_T *wp, linenr_T first, linenr_T last, int limit_winheight);
int plines_m_win(win_T *wp, linenr_T first, linenr_T last, int max);
int gchar_pos(pos_T *pos);
int gchar_cursor(void);
void pchar_cursor(int c);
Expand Down