runtime(jq): fix undefined variable s:save_cpoptions in ftplugin #14661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks, see also #14663 I'll merge those two together :) |
clason
added a commit
to clason/neovim
that referenced
this pull request
Apr 29, 2024
runtime(jq): remove undefined var s:save_cpoptions and add include setting closes: vim/vim#14661 closes: vim/vim#14663 vim/vim@dc5c905 Co-authored-by: GodFather <vito.blog@gmail.com> Co-authored-by: itchyny <itchyny@cybozu.co.jp>
clason
added a commit
to neovim/neovim
that referenced
this pull request
Apr 29, 2024
runtime(jq): remove undefined var s:save_cpoptions and add include setting closes: vim/vim#14661 closes: vim/vim#14663 vim/vim@dc5c905 Co-authored-by: GodFather <vito.blog@gmail.com> Co-authored-by: itchyny <itchyny@cybozu.co.jp>
phanen
pushed a commit
to phanen/neovim
that referenced
this pull request
May 3, 2024
runtime(jq): remove undefined var s:save_cpoptions and add include setting closes: vim/vim#14661 closes: vim/vim#14663 vim/vim@dc5c905 Co-authored-by: GodFather <vito.blog@gmail.com> Co-authored-by: itchyny <itchyny@cybozu.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue about undefined variable in the jq ftplugin file. It is recommended not to setting 'cpo' if unnecessary (#14619 (comment)), I removed the resetting lines instead of adding
let s:save_cpooptions = &cpooptionsandset cpo&vim.