fixup(i3/swayconfig): floating_modifier
#14841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM and it fixes the issue I had previously seen. |
|
Thanks! |
clason
added a commit
to clason/neovim
that referenced
this pull request
May 24, 2024
…r highlight (vim/vim#14841) vim/vim@b1ffc52 Co-authored-by: Josef Litoš <54900518+JosefLitos@users.noreply.github.com>
clason
added a commit
to neovim/neovim
that referenced
this pull request
May 25, 2024
…r highlight (vim/vim#14841) vim/vim@b1ffc52 Co-authored-by: Josef Litoš <54900518+JosefLitos@users.noreply.github.com>
huangyingw
pushed a commit
to huangyingw/neovim
that referenced
this pull request
May 31, 2024
…r highlight (vim/vim#14841) vim/vim@b1ffc52 Co-authored-by: Josef Litoš <54900518+JosefLitos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup of #14827
Also removed the
+from valid modkey sequence becausefloating_modifierdoesn't allow multiple keys (whereasbar.modifierdoes, so that's why it was there originally).(@jamespeapen)