Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved test coverage of syntax.c #1624

Closed
wants to merge 3 commits into from
Closed

Conversation

dpelle
Copy link
Member

@dpelle dpelle commented Apr 9, 2017

This PR improves test coverage of syntax.c:

  • exercise more invalid argument errors for the :syntax and :highlight commands
  • more coverage of syntax completion for :highlight command

@dpelle
Copy link
Member Author

dpelle commented Apr 9, 2017

While improving test coverage of vim/src/syntax.c, I stumbled upon this
easter egg which results in an animation:

  $ vim -u NONE -c 'call feedkeys(":hi Ni \<C-D>")'

I did not add a test for it, as a test would take a few seconds.

See also:

  :Ni!

And:
https://www.youtube.com/watch?v=zIV4poUZAQo

@codecov-io
Copy link

Codecov Report

Merging #1624 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1624      +/-   ##
==========================================
+ Coverage   74.79%   74.82%   +0.02%     
==========================================
  Files          76       76              
  Lines      124860   124860              
==========================================
+ Hits        93391    93421      +30     
+ Misses      31469    31439      -30
Impacted Files Coverage Δ
src/message.c 68.07% <0%> (-0.46%) ⬇️
src/channel.c 83.64% <0%> (-0.24%) ⬇️
src/window.c 81.08% <0%> (-0.17%) ⬇️
src/os_unix.c 58.29% <0%> (-0.15%) ⬇️
src/term.c 53.38% <0%> (-0.06%) ⬇️
src/gui_gtk_x11.c 47.39% <0%> (-0.06%) ⬇️
src/gui_beval.c 44.89% <0%> (+0.92%) ⬆️
src/syntax.c 76.72% <0%> (+1.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f803a76...2a6cc35. Read the comment docs.

@brammool brammool closed this in ea58815 Apr 10, 2017
desvp pushed a commit to desvp/vim that referenced this pull request May 30, 2017
Problem:    Not enough test coverage for syntax commands.
Solution:   Add a few more tests. (Dominique Pelle, closes vim#1624)
janlazo added a commit to janlazo/neovim that referenced this pull request Jun 2, 2018
Problem:    Not enough test coverage for syntax commands.
Solution:   Add a few more tests. (Dominique Pelle, closes vim/vim#1624)
vim/vim@ea58815
janlazo added a commit to janlazo/neovim that referenced this pull request Jun 2, 2018
Problem:    Not enough test coverage for syntax commands.
Solution:   Add a few more tests. (Dominique Pelle, closes vim/vim#1624)
vim/vim@ea58815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants