Prevent a buffer-overflow when parsing the qf results #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to re-allocate a bigger buffer even when the old one has the same exact size of the text we're going to write over using vim_strncpy. This is obvious in hindsight as vim_strncpy expects 'out' to be len+1 bytes long, failure to do so resulted in silent memory corruption leading to a crash.
Codecov Report
@@ Coverage Diff @@
## master #1694 +/- ##
==========================================
+ Coverage 74.85% 74.88% +0.03%
==========================================
Files 76 76
Lines 124942 124943 +1
==========================================
+ Hits 93521 93569 +48
+ Misses 31421 31374 -47
Continue to review full report at Codecov.
|
desvp
pushed a commit
to desvp/vim
that referenced
this pull request
May 30, 2017
Problem: Off-by-one error in buffer size computation. Solution: Use ">=" instead of ">". (Lemonboy, closes vim#1694)
dpelle
pushed a commit
to dpelle/vim
that referenced
this pull request
Jul 31, 2017
Problem: Off-by-one error in buffer size computation. Solution: Use ">=" instead of ">". (Lemonboy, closes vim#1694)
jamessan
added a commit
to jamessan/neovim
that referenced
this pull request
Dec 19, 2017
Problem: Off-by-one error in buffer size computation. Solution: Use ">=" instead of ">". (Lemonboy, closes vim/vim#1694) vim/vim@253f912
jamessan
added a commit
to jamessan/neovim
that referenced
this pull request
Dec 19, 2017
Problem: Off-by-one error in buffer size computation. Solution: Use ">=" instead of ">". (Lemonboy, closes vim/vim#1694) vim/vim@253f912
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to re-allocate a bigger buffer even when the old one has the
same exact size of the text we're going to write over using vim_strncpy.
This is obvious in hindsight as vim_strncpy expects 'out' to be len+1
bytes long, failure to do so resulted in silent memory corruption
leading to a crash.