-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update syntax file for .cabal #1777
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1777 +/- ##
==========================================
- Coverage 75.11% 75.1% -0.01%
==========================================
Files 76 76
Lines 124994 125034 +40
==========================================
+ Hits 93886 93913 +27
- Misses 31108 31121 +13
Continue to review full report at Codecov.
|
did you contact the maintainer of the file? |
@Twinside What's your opinion on making this change upstreamed (vim/vim) ? |
please note, that runtime file changes should be evaluated and processed by their respective maintainer. If they approve the change, they will send an update to Bram for inclusion with Vim. We don't generally process changes here, as long as the runtime file maintainer is not missing. |
The maintener seems not responding (bump @Twinside), while the changes are really nice to have. |
Instead of using ":syn match" with \c in the pattern, use ":syn case ignore" and ":syn keyword". It's a lot faster. |
Yeah go ahead, I don't really have time to track the update to the cabal files |
If you agree I can become the new maintainer of this file. |
closin for #2922 |
Incorporate changes in https://github.com/sdiehl/haskell-vim-proto/blob/master/vim/syntax/cabal.vim, notably: