Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syntax file for .cabal #1777

Closed
wants to merge 1 commit into from
Closed

Conversation

MaskRay
Copy link

@MaskRay MaskRay commented Jun 17, 2017

Incorporate changes in https://github.com/sdiehl/haskell-vim-proto/blob/master/vim/syntax/cabal.vim, notably:

  • field names are case-insensitive
  • allow whitespace between the field name and the colon

@codecov-io
Copy link

Codecov Report

Merging #1777 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1777      +/-   ##
==========================================
- Coverage   75.11%    75.1%   -0.01%     
==========================================
  Files          76       76              
  Lines      124994   125034      +40     
==========================================
+ Hits        93886    93913      +27     
- Misses      31108    31121      +13
Impacted Files Coverage Δ
src/if_xcmdsrv.c 83.33% <0%> (-2.04%) ⬇️
src/os_unix.c 58.34% <0%> (-0.49%) ⬇️
src/gui.c 45.53% <0%> (-0.11%) ⬇️
src/gui_gtk_x11.c 47.39% <0%> (-0.11%) ⬇️
src/window.c 81.25% <0%> (-0.1%) ⬇️
src/channel.c 83.8% <0%> (ø) ⬆️
src/message.c 68.52% <0%> (+0.05%) ⬆️
src/if_py_both.h 76.01% <0%> (+0.7%) ⬆️
src/gui_beval.c 44.89% <0%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cf9128...10053f1. Read the comment docs.

@chrisbra
Copy link
Member

did you contact the maintainer of the file?

@MaskRay
Copy link
Author

MaskRay commented Jun 19, 2017

@Twinside What's your opinion on making this change upstreamed (vim/vim) ?

@chrisbra
Copy link
Member

please note, that runtime file changes should be evaluated and processed by their respective maintainer. If they approve the change, they will send an update to Bram for inclusion with Vim. We don't generally process changes here, as long as the runtime file maintainer is not missing.

@coot
Copy link
Contributor

coot commented May 15, 2018

The maintener seems not responding (bump @Twinside), while the changes are really nice to have.

@brammool
Copy link
Contributor

Instead of using ":syn match" with \c in the pattern, use ":syn case ignore" and ":syn keyword". It's a lot faster.

@Twinside
Copy link

Yeah go ahead, I don't really have time to track the update to the cabal files

@coot
Copy link
Contributor

coot commented May 15, 2018

If you agree I can become the new maintainer of this file.

@coot coot mentioned this pull request May 16, 2018
@chrisbra
Copy link
Member

closin for #2922

@chrisbra chrisbra closed this May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants