Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scrollback #1891

Closed
wants to merge 1 commit into from
Closed

fix scrollback #1891

wants to merge 1 commit into from

Conversation

mattn
Copy link
Member

@mattn mattn commented Jul 29, 2017

multibyte characters are broken in scrollback, <ff> is inserted in per characters.

@codecov-io
Copy link

codecov-io commented Jul 29, 2017

Codecov Report

Merging #1891 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1891      +/-   ##
==========================================
+ Coverage   75.07%   75.11%   +0.04%     
==========================================
  Files          76       76              
  Lines      125304   125303       -1     
==========================================
+ Hits        94074    94125      +51     
+ Misses      31230    31178      -52
Impacted Files Coverage Δ
src/if_py_both.h 76.01% <0%> (-0.01%) ⬇️
src/gui.c 45.58% <0%> (ø) ⬆️
src/evalfunc.c 82.45% <0%> (+0.02%) ⬆️
src/eval.c 80.65% <0%> (+0.04%) ⬆️
src/window.c 81.42% <0%> (+0.09%) ⬆️
src/channel.c 83.64% <0%> (+0.18%) ⬆️
src/gui_gtk_x11.c 47.6% <0%> (+0.2%) ⬆️
src/os_unix.c 57.43% <0%> (+0.38%) ⬆️
src/message.c 68.35% <0%> (+0.45%) ⬆️
src/version.c 79.29% <0%> (+2.52%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcbfa33...96674f3. Read the comment docs.

@brammool brammool closed this in 696d00f Jul 29, 2017
dpelle pushed a commit to dpelle/vim that referenced this pull request Jul 31, 2017
Problem:    Terminal window scrollback contents is wrong.
Solution:   Fix handling of multi-byte characters (Yasuhiro Matsumoto) Handle
            empty lines correctly. (closes vim#1891)
@mattn mattn deleted the fix-scrollback branch August 11, 2017 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants