Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cursor to the leftmost column of window when scrolling if left margin is used. #3016

Closed
wants to merge 1 commit into from

Conversation

ttdoda
Copy link

@ttdoda ttdoda commented Jun 15, 2018

If cursor is in the outside of margin, VT525 and xterm ignore some control sequences (e.g. IL, DL).

Following setting enables to use right and left margin when scrolling.

let &t_ti .= "\e[?69h"
let &t_te .= "\e7\e[?69l\e8"
let &t_CV = "\e[%i%p1%d;%p2%ds"

But xterm (and VT525) does not scroll correctly if window is not leftmost in screen.
This patch fixes this problem.

…argin is used.

If cursor is in the outside of margin, VT525 and xterm ignore some control
sequences (e.g. IL, DL).
@codecov-io
Copy link

Codecov Report

Merging #3016 into master will increase coverage by <.01%.
The diff coverage is 46.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3016      +/-   ##
==========================================
+ Coverage   75.84%   75.85%   +<.01%     
==========================================
  Files          92       92              
  Lines      135295   135301       +6     
==========================================
+ Hits       102620   102633      +13     
+ Misses      32675    32668       -7
Impacted Files Coverage Δ
src/screen.c 76.66% <46.66%> (-0.02%) ⬇️
src/if_xcmdsrv.c 84.35% <0%> (-1.08%) ⬇️
src/terminal.c 72.74% <0%> (-0.17%) ⬇️
src/channel.c 83.16% <0%> (-0.08%) ⬇️
src/os_unix.c 54.38% <0%> (-0.05%) ⬇️
src/ex_docmd.c 77.05% <0%> (-0.02%) ⬇️
src/window.c 82.22% <0%> (+0.03%) ⬆️
src/eval.c 81.52% <0%> (+0.04%) ⬆️
src/gui_gtk_x11.c 47.98% <0%> (+0.09%) ⬆️
src/term.c 59.94% <0%> (+0.15%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d3aae...a3efa1d. Read the comment docs.

@brammool brammool closed this in bfa4246 Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants