Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filetype support for WebAssembly text format #3264

Closed
wants to merge 2 commits into from

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Jul 29, 2018

Problem

Vim does not support WebAssembly text format

Solution

This PR adds support for the WebAsembly text format to Vim.

WebAssembly is a new executable format for browsers. Since WebAssembly spec is defined by W3C, the spec is one of long live web standards.

https://webassembly.org/

I had created a project vim-wasm to support the text format. And today, I refined it following WebAssembly Spec. Now it can highlight the text format very well.

This is an example of highlighting using my project vim.wasm:

highlighting example

@codecov-io
Copy link

codecov-io commented Jul 29, 2018

Codecov Report

Merging #3264 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3264      +/-   ##
==========================================
- Coverage   76.57%   76.55%   -0.03%     
==========================================
  Files          93       93              
  Lines      136843   136839       -4     
==========================================
- Hits       104793   104755      -38     
- Misses      32050    32084      +34
Impacted Files Coverage Δ
src/gui_beval.c 55.02% <0%> (-6.56%) ⬇️
src/window.c 81.87% <0%> (-0.49%) ⬇️
src/gui_gtk_x11.c 48.03% <0%> (-0.15%) ⬇️
src/ex_cmds2.c 82.63% <0%> (-0.1%) ⬇️
src/normal.c 74.35% <0%> (-0.08%) ⬇️
src/undo.c 83.09% <0%> (-0.07%) ⬇️
src/screen.c 76.71% <0%> (-0.05%) ⬇️
src/edit.c 85.41% <0%> (-0.01%) ⬇️
src/misc1.c 84.29% <0%> (-0.01%) ⬇️
src/misc2.c 80.64% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 612cc38...c4555b5. Read the comment docs.

@brammool
Copy link
Contributor

brammool commented Jul 29, 2018 via email

@rhysd
Copy link
Contributor Author

rhysd commented Jul 29, 2018

@brammool Thank you for your quick reviews! I addressed the points at c4555b5

@brammool
Copy link
Contributor

I'll include it, thanks. It would be nice to have your full name for the Maintainer line.

@brammool brammool closed this Jul 29, 2018
@rhysd
Copy link
Contributor Author

rhysd commented Jul 30, 2018

@brammool

Thank you. I'll wait for the changes being included.

It would be nice to have your full name for the Maintainer line.

Yeah, I considered that, but I'm basically not making my full name public on the Internet. When my mind changes, I'll send a patch to update the 'Maintainer:' lines. Thank you for your suggestion.

@rhysd
Copy link
Contributor Author

rhysd commented Jul 31, 2018

I confirmed these changes were included in master branch. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants