New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filetype support for WebAssembly text format #3264
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3264 +/- ##
==========================================
- Coverage 76.57% 76.55% -0.03%
==========================================
Files 93 93
Lines 136843 136839 -4
==========================================
- Hits 104793 104755 -38
- Misses 32050 32084 +34
Continue to review full report at Codecov.
|
Linda wrote:
## Problem
Vim does not support [WebAssembly text format][spec]
## Solution
This PR adds support for the WebAsembly text format to Vim.
WebAssembly is a new executable format for browsers. Since WebAssembly spec is defined by [W3C](https://www.w3.org/community/webassembly/), the spec is one of long live web standards.
https://webassembly.org/
I had created a project [vim-wasm](https://github.com/rhysd/vim-wasm) to support the text format. And today, I refined it following [WebAssembly Spec][spec]. Now it can highlight the text format very well.
This is an example of highlighting using my project [vim.wasm](https://github.com/rhysd/vim.wasm):
<img width="424" alt="highlighting example" src="https://user-images.githubusercontent.com/823277/43366973-8377bdf8-9380-11e8-8ca7-a912768e6e10.png">
[spec]: https://webassembly.github.io/spec/core/text/index.html
Thanks for working on this.
In the indent file you set the 'lisp' option. This has side effects.
Instead, I would recommend to use the lispindent() function. Unless the
side effects are actually desired.
In the syntax file I would recomment setting 'cpo', like it's done in
many. Even when you don't use line continuation, it also affects some
details about regexp pattern matching.
…--
You know you use Vim too much when you have this alias in your
~/.bashrc file: alias :e=/bin/vim (Eljay Love-Jensen)
/// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
I'll include it, thanks. It would be nice to have your full name for the Maintainer line. |
Thank you. I'll wait for the changes being included.
Yeah, I considered that, but I'm basically not making my full name public on the Internet. When my mind changes, I'll send a patch to update the 'Maintainer:' lines. Thank you for your suggestion. |
I confirmed these changes were included in master branch. Thank you. |
Problem
Vim does not support WebAssembly text format
Solution
This PR adds support for the WebAsembly text format to Vim.
WebAssembly is a new executable format for browsers. Since WebAssembly spec is defined by W3C, the spec is one of long live web standards.
https://webassembly.org/
I had created a project vim-wasm to support the text format. And today, I refined it following WebAssembly Spec. Now it can highlight the text format very well.
This is an example of highlighting using my project vim.wasm: