test_filter_cmd: Ensure 'helplang' is set before trying to filter for it #3591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ":set" only shows options with non-default values, ensure 'helplang' has a value before trying to filter for it.
Codecov Report
@@ Coverage Diff @@
## master #3591 +/- ##
==========================================
+ Coverage 77.32% 77.32% +<.01%
==========================================
Files 99 99
Lines 139177 139176 -1
==========================================
+ Hits 107614 107621 +7
+ Misses 31563 31555 -8
Continue to review full report at Codecov.
|
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jul 1, 2019
Problem: Filter command test may fail if helplang is not set. Solution: Set 'helplang' for the test. (James McCoy, closes vim/vim#3591) vim/vim@bd9a0c6
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jul 3, 2019
Problem: Filter command test may fail if helplang is not set. Solution: Set 'helplang' for the test. (James McCoy, closes vim/vim#3591) vim/vim@bd9a0c6
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jul 3, 2019
Problem: Filter command test may fail if helplang is not set. Solution: Set 'helplang' for the test. (James McCoy, closes vim/vim#3591) vim/vim@bd9a0c6
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jul 6, 2019
Problem: Filter command test may fail if helplang is not set. Solution: Set 'helplang' for the test. (James McCoy, closes vim/vim#3591) vim/vim@bd9a0c6
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jul 8, 2019
Problem: Filter command test may fail if helplang is not set. Solution: Set 'helplang' for the test. (James McCoy, closes vim/vim#3591) vim/vim@bd9a0c6
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jul 9, 2019
Problem: Filter command test may fail if helplang is not set. Solution: Set 'helplang' for the test. (James McCoy, closes vim/vim#3591) vim/vim@bd9a0c6
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jul 10, 2019
Problem: Filter command test may fail if helplang is not set. Solution: Set 'helplang' for the test. (James McCoy, closes vim/vim#3591) vim/vim@bd9a0c6
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jul 10, 2019
Problem: Filter command test may fail if helplang is not set. Solution: Set 'helplang' for the test. (James McCoy, closes vim/vim#3591) vim/vim@bd9a0c6
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jul 13, 2019
Problem: Filter command test may fail if helplang is not set. Solution: Set 'helplang' for the test. (James McCoy, closes vim/vim#3591) vim/vim@bd9a0c6
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jul 14, 2019
Problem: Filter command test may fail if helplang is not set. Solution: Set 'helplang' for the test. (James McCoy, closes vim/vim#3591) vim/vim@bd9a0c6
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jul 15, 2019
Problem: Filter command test may fail if helplang is not set. Solution: Set 'helplang' for the test. (James McCoy, closes vim/vim#3591) vim/vim@bd9a0c6
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jul 16, 2019
Problem: Filter command test may fail if helplang is not set. Solution: Set 'helplang' for the test. (James McCoy, closes vim/vim#3591) vim/vim@bd9a0c6
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jul 16, 2019
Problem: Filter command test may fail if helplang is not set. Solution: Set 'helplang' for the test. (James McCoy, closes vim/vim#3591) vim/vim@bd9a0c6
timeyyy
pushed a commit
to timeyyy/neovim
that referenced
this pull request
Aug 9, 2019
Problem: Filter command test may fail if helplang is not set. Solution: Set 'helplang' for the test. (James McCoy, closes vim/vim#3591) vim/vim@bd9a0c6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ":set" only shows options with non-default values, ensure
'helplang' has a value before trying to filter for it.