Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_statusline() could fail in very big terminal #4255

Closed

Conversation

Projects
None yet
2 participants
@dpelle
Copy link

dpelle commented Apr 14, 2019

test_statusline() could fail in very big terminals:

  • test was checking that statusline shows "Top" when at top of the file or "Bottom" at end of the file, but it could show "All" when when the terminal has many lines (more than ~200). It should now pass with ~10000 lines.
  • test of was checking truncation in statusline with %< but that could fail if terminal has many columns (more than ~1000 so no truncation happened). It should now pass with ~4000 columns.

In both cases, it is fixed by increasing thresholds. So in theory test could still fail on very large terminals. However the thresholds are now so large that it passes all the times for all practical cases. It passes e.g. on my 4K screen, with a full screen terminal and a tiny/unreadable font of size of 3 (and that's a 412 lines x 1913 col terminal, so it would pass on still bigger terminals).

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 14, 2019

Codecov Report

Merging #4255 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4255      +/-   ##
==========================================
+ Coverage   79.71%   79.75%   +0.04%     
==========================================
  Files         106      106              
  Lines      141579   141579              
==========================================
+ Hits       112858   112916      +58     
+ Misses      28721    28663      -58
Impacted Files Coverage Δ
src/window.c 86.26% <0%> (-0.1%) ⬇️
src/screen.c 80.55% <0%> (-0.07%) ⬇️
src/gui_gtk_x11.c 48.86% <0%> (-0.05%) ⬇️
src/ex_cmds.c 81.77% <0%> (+0.09%) ⬆️
src/sign.c 93.51% <0%> (+0.12%) ⬆️
src/netbeans.c 27.44% <0%> (+0.22%) ⬆️
src/memline.c 76.94% <0%> (+0.36%) ⬆️
src/syntax.c 79.61% <0%> (+0.71%) ⬆️
src/gui.c 58.51% <0%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0aaf3c...bb40c33. Read the comment docs.

@brammool brammool closed this in 316c167 Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.