test_statusline() could fail in very big terminal #4255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4255 +/- ##
==========================================
+ Coverage 79.71% 79.75% +0.04%
==========================================
Files 106 106
Lines 141579 141579
==========================================
+ Hits 112858 112916 +58
+ Misses 28721 28663 -58
Continue to review full report at Codecov.
|
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
May 24, 2019
Problem: Statusline test could fail in large terminal.
Solution: Make the test work on a huge terminal. (Dominique Pelle,
closes vim/vim#4255)
vim/vim@316c167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_statusline()could fail in very big terminals:%<but that could fail if terminal has many columns (more than ~1000 so no truncation happened). It should now pass with ~4000 columns.In both cases, it is fixed by increasing thresholds. So in theory test could still fail on very large terminals. However the thresholds are now so large that it passes all the times for all practical cases. It passes e.g. on my 4K screen, with a full screen terminal and a tiny/unreadable font of size of 3 (and that's a 412 lines x 1913 col terminal, so it would pass on still bigger terminals).