More fixes for wrapping in :args #4737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4737 +/- ##
==========================================
- Coverage 81.39% 80.12% -1.28%
==========================================
Files 115 111 -4
Lines 145353 138277 -7076
==========================================
- Hits 118309 110790 -7519
- Misses 27044 27487 +443
Continue to review full report at Codecov.
|
blueyed
commented
Jul 27, 2019
| " No trailing newline with one item per row. | ||
| let long_arg = repeat('X', 81) | ||
| exe 'args '.long_arg | ||
| call assert_equal("\n[".long_arg.']', execute('args')) |
There was a problem hiding this comment.
Could be done in Test_large_arg also instead.
blueyed
added a commit
to blueyed/neovim
that referenced
this pull request
Jul 27, 2019
Problem: :args output is not aligned. Solution: Output a line break after the last item in a row. vim/vim@74da393 vim-patch:8.1.1750: depending on the terminal width :version may miss a line break Problem: Depending on the terminal width :version may miss a line break. Solution: Add a line break when needed. vim/vim@8a5c29a vim-patch:8.1.1760: extra line break for wrapping output of :args Problem: Extra line break for wrapping output of :args. Solution: Avoid the extra line break. (Daniel Hahler, closes vim/vim#4737) vim/vim@9800bfe
blueyed
added a commit
to neovim/neovim
that referenced
this pull request
Jul 27, 2019
Problem: :args output is not aligned. Solution: Output a line break after the last item in a row. vim/vim@74da393 vim-patch:8.1.1750: depending on the terminal width :version may miss a line break Problem: Depending on the terminal width :version may miss a line break. Solution: Add a line break when needed. vim/vim@8a5c29a vim-patch:8.1.1760: extra line break for wrapping output of :args Problem: Extra line break for wrapping output of :args. Solution: Avoid the extra line break. (Daniel Hahler, closes vim/vim#4737) vim/vim@9800bfe
timeyyy
pushed a commit
to timeyyy/neovim
that referenced
this pull request
Aug 9, 2019
Problem: :args output is not aligned. Solution: Output a line break after the last item in a row. vim/vim@74da393 vim-patch:8.1.1750: depending on the terminal width :version may miss a line break Problem: Depending on the terminal width :version may miss a line break. Solution: Add a line break when needed. vim/vim@8a5c29a vim-patch:8.1.1760: extra line break for wrapping output of :args Problem: Extra line break for wrapping output of :args. Solution: Avoid the extra line break. (Daniel Hahler, closes vim/vim#4737) vim/vim@9800bfe
manuelschiller
pushed a commit
to manuelschiller/vim
that referenced
this pull request
Nov 10, 2019
Problem: Extra line break for wrapping output of :args. Solution: Avoid the extra line break. (Daniel Hahler, closes vim#4737)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.