Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove Test_popup_and_window_resize from s:flaky_tests #4807

Closed
wants to merge 1 commit into from

Conversation

@blueyed
Copy link

commented Aug 12, 2019

This should have been fixed in #2186 (v8.0.1179).

tests: remove Test_popup_and_window_resize from s:flaky_tests
This should have been fixed in #2186 (v8.0.1179).
@codecov-io

This comment has been minimized.

Copy link

commented Aug 12, 2019

Codecov Report

Merging #4807 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4807      +/-   ##
==========================================
+ Coverage   81.55%   81.55%   +<.01%     
==========================================
  Files         118      118              
  Lines      145681   145681              
==========================================
+ Hits       118804   118806       +2     
+ Misses      26877    26875       -2
Impacted Files Coverage Δ
src/term.c 79.12% <0%> (-0.06%) ⬇️
src/message.c 76.94% <0%> (-0.05%) ⬇️
src/gui.c 63.75% <0%> (+0.05%) ⬆️
src/if_xcmdsrv.c 86.35% <0%> (+0.17%) ⬆️
src/profiler.c 93.25% <0%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e3cc1...a19aefa. Read the comment docs.

@brammool brammool closed this in 9570aac Aug 12, 2019

@brammool

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

blueyed added a commit to blueyed/neovim that referenced this pull request Aug 13, 2019

vim-patch:8.1.1842: test listed as flaky should no longer be flaky
Problem:    Test listed as flaky should no longer be flaky.
Solution:   Remove Test_popup_and_window_resize from the list of flaky tests.
            (Daniel Hahler, close vim/vim#4807)
vim/vim@9570aac

blueyed added a commit to blueyed/neovim that referenced this pull request Aug 13, 2019

vim-patch:8.1.1842: test listed as flaky should no longer be flaky
Problem:    Test listed as flaky should no longer be flaky.
Solution:   Remove Test_popup_and_window_resize from the list of flaky tests.
            (Daniel Hahler, close vim/vim#4807)
vim/vim@9570aac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.