Add pum_getpos() to return the position and size of the popup menu #4827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puremourning
force-pushed
the
pum_getpos
branch
4 times, most recently
from
f8d0570
to
5ca797c
Compare
puremourning
force-pushed
the
pum_getpos
branch
from
5ca797c
to
c1d5fed
Compare
Codecov Report
@@ Coverage Diff @@
## master #4827 +/- ##
==========================================
+ Coverage 81.5% 81.57% +0.07%
==========================================
Files 119 119
Lines 145708 145737 +29
==========================================
+ Hits 118761 118891 +130
+ Misses 26947 26846 -101
Continue to review full report at Codecov.
|
manuelschiller
pushed a commit
to manuelschiller/vim
that referenced
this pull request
Nov 10, 2019
Problem: Cannot get size and position of the popup menu. Solution: Add pum_getpos(). (Ben Jackson, closes vim#4827)
sethfowler
added a commit
to sethfowler/neovim
that referenced
this pull request
Dec 15, 2019
This is a straightforward port to neovim of the pum_getpos() API added to vim in vim/vim#4827.
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Dec 29, 2019
Problem: Cannot get size and position of the popup menu. Solution: Add pum_getpos(). (Ben Jackson, closes vim/vim#4827) vim/vim@e9bd572 neovim#11562 backported the vim patch. This patch only updates the runtime/doc/ files to match Vim.
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Dec 29, 2019
Problem: Cannot get size and position of the popup menu. Solution: Add pum_getpos(). (Ben Jackson, closes vim/vim#4827) vim/vim@e9bd572 neovim#11562 backported the vim patch. This patch only updates the runtime/doc/ files to match Vim.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #4823
Add pum_getpos() returning the same size and position information as
CompleteChanged.useful for plugins to avoid overlapping the PUM when placing popup windows. Also useful for testing.