test42: set cpo+=S, add to .gitattributes #5072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- "set cpo+=S" is implied via `vim -u …` used to run the tests (which uses `nocompatible`), but makes sense to have it explicit, since it caused confusion when failing with Neovim (neovim/neovim#10679 (comment)). - force textual diff via .gitattributes - otherwise Git (2.23.0) considers it to be binary.
blueyed
changed the title
blueyed
added a commit
to blueyed/neovim
that referenced
this pull request
Oct 19, 2019
Problem: Test42 seen as binary by git diff.
Solution: Add .gitattributes file. Make explicit that 'cpo' does not
contain 'S'. (Daniel Hahler, closes vim/vim#5072)
vim/vim@5b39d7a
justinmk
pushed a commit
to neovim/neovim
that referenced
this pull request
Oct 19, 2019
Problem: Test42 seen as binary by git diff.
Solution: Add .gitattributes file. Make explicit that 'cpo' does not
contain 'S'. (Daniel Hahler, closes vim/vim#5072)
vim/vim@5b39d7a
manuelschiller
pushed a commit
to manuelschiller/vim
that referenced
this pull request
Nov 10, 2019
Problem: Test42 seen as binary by git diff.
Solution: Add .gitattributes file. Make explicit that 'cpo' does not
contain 'S'. (Daniel Hahler, closes vim#5072)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"set cpo+=S" is implied via
vim -u …used to run the tests (whichuses
nocompatible), but makes sense to have it explicit, since itcaused confusion when failing with Neovim
([RFC] Fix oldtest on Windows neovim/neovim#10679 (comment)).
force textual diff via .gitattributes - otherwise Git (2.23.0)
considers it to be binary.