src/configure.ac: fix gcc-10 pattern detection #5580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On gcc-10 `./configure` can't detect correct value of `-D_FORTIFY_SOURCE=`: ``` $ ./configure ... checking for GCC 3 or later... auto/configure: line 14735: test: 10.0.1: integer expression expected no checking whether we need -D_FORTIFY_SOURCE=1... auto/configure: line 14745: test: 10.0.1: integer expression expected no ``` ``` $ gcc -dumpversion 10.0.1 ``` It was noticed as vim buffer overflow detection as gentoo default to `-D_FORTIFY_SOURCE=2`: https://bugs.gentoo.org/706324#c2 The fix extends sed regex to catch multiple digits in major version. Reported-by: lekto@o2.pl Bug: https://bugs.gentoo.org/706324 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On gcc-10
./configurecan't detect correct value of-D_FORTIFY_SOURCE=:It was noticed as vim buffer overflow detection as gentoo default to
-D_FORTIFY_SOURCE=2: https://bugs.gentoo.org/706324#c2The fix extends sed regex to catch multiple digits in major version.
Reported-by: lekto@o2.pl
Bug: https://bugs.gentoo.org/706324