Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Some improvements to the GHA environemnt #6798

Closed
wants to merge 2 commits into from

Conversation

k-takata
Copy link
Member

Extracted from #6795.

  • Fix that some tests were not executed on GHA.
    To fix this, copy all the files in src/ (not only src/testdir/) to src2/, and fix some tests.
    (The tests for gvim.exe is run at src/testdir/, and the tests for vim.exe is run at src2/testdir/.)
  • Update the flaky tests list.
    Some tests are flaky on GHA. Test_BufWrite_lockmarks() and Test_bufunload_all() are added to the list.
    Actually, there are some more flaky tests on GHA, but at least these two tests are often failed.
    (I tried to fix them, but I couldn't. They don't reproduce in my local environment.)

@codecov
Copy link

codecov bot commented Aug 30, 2020

Codecov Report

Merging #6798 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6798      +/-   ##
==========================================
- Coverage   88.51%   88.51%   -0.01%     
==========================================
  Files         147      147              
  Lines      160891   160891              
==========================================
- Hits       142414   142411       -3     
- Misses      18477    18480       +3     
Impacted Files Coverage Δ
src/netbeans.c 76.07% <0.00%> (-0.23%) ⬇️
src/gui.c 63.30% <0.00%> (-0.15%) ⬇️
src/message.c 88.48% <0.00%> (-0.05%) ⬇️
src/terminal.c 90.98% <0.00%> (-0.04%) ⬇️
src/gui_gtk_x11.c 58.73% <0.00%> (ø)
src/window.c 92.50% <0.00%> (+0.03%) ⬆️
src/channel.c 89.83% <0.00%> (+0.03%) ⬆️
src/clipboard.c 83.31% <0.00%> (+0.10%) ⬆️
src/if_xcmdsrv.c 88.90% <0.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a563984...fd95e94. Read the comment docs.

@k-takata
Copy link
Member Author

@brammool I think this is worth to be merged.
This fixes some issues with current tests on GHA.

  • Fix that some tests were not executed on GHA.

We have more than 3,000 tests, but only about 1,600 tests were executed on the console version on GHA.

@brammool brammool closed this in 7d69796 Aug 31, 2020
@k-takata k-takata deleted the gha-improve branch August 31, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI GHA, Cirrus, AppVeyor, ... platform-windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant