Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use %~dpf0 to make sure path to the vimtutor.bat #6966

Closed
wants to merge 4 commits into from

Conversation

mattn
Copy link
Member

@mattn mattn commented Sep 16, 2020

If the current directory is not the same as vimtutor.bat, vimtutor.bat will not work.

additional

%0 does not mean full-path to the batch file.

@mattn mattn changed the title Use %~dpf0 to make sure to path to the vimtutor.bat Use %~dpf0 to make sure path to the vimtutor.bat Sep 16, 2020
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #6966 (0344082) into master (7851c69) will increase coverage by 7.60%.
The diff coverage is n/a.

❗ Current head 0344082 differs from pull request most recent head c77ee1c. Consider uploading reports for the commit c77ee1c to get more accurate results

@@            Coverage Diff             @@
##           master    #6966      +/-   ##
==========================================
+ Coverage   80.95%   88.55%   +7.60%     
==========================================
  Files         161      148      -13     
  Lines      185498   161431   -24067     
  Branches    41929        0   -41929     
==========================================
- Hits       150174   142961    -7213     
+ Misses      22780    18470    -4310     
+ Partials    12544        0   -12544     
Flag Coverage Δ
huge-clang-none ?
linux ?
mingw-x64-HUGE ?
mingw-x64-HUGE-gui ?
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/libvterm/src/unicode.c 70.83% <0.00%> (-13.17%) ⬇️
src/gui.c 62.75% <0.00%> (-10.27%) ⬇️
src/fold.c 86.59% <0.00%> (-1.53%) ⬇️
src/job.c 89.81% <0.00%> (-0.36%) ⬇️
src/blob.c 91.83% <0.00%> (-0.09%) ⬇️
src/dosinst.c
src/uninstall.c
src/vim9instr.c
src/float.c
src/vim9expr.c
... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7851c69...c77ee1c. Read the comment docs.

@Houl
Copy link
Contributor

Houl commented Sep 16, 2020

%~dpf0 is long for %~f0 which already has the fully-qualified file name.

vimtutor.bat Outdated Show resolved Hide resolved
mattn and others added 2 commits April 21, 2022 23:40
@mattn
Copy link
Member Author

mattn commented Apr 21, 2022

So this is already fixed.

@mattn mattn closed this Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants