Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Test_popup_atcursor_pos failed when +conceal feature not available #8505

Closed
wants to merge 1 commit into from
Closed

Test Test_popup_atcursor_pos failed when +conceal feature not available #8505

wants to merge 1 commit into from

Conversation

dpelle
Copy link
Member

@dpelle dpelle commented Jul 3, 2021

This PR fixes Test_popup_atcursor_pos which failed when the +conceal feature is not available.
This happens at least with Vim-8.2.3089.

The test used the conceal feature without checking whether the feature is available.

To reproduce:

$ ./configure --with-features=normal --enable-gui=none --enable-terminal
$ make - j8
$ make test_popupwin
...snip...
Executed 103 tests                       in  14.698552 seconds
1 FAILED:
Found errors in Test_popup_atcursor_pos():
Run 1:
command line..script /home/pel/sb/vim/src/testdir/runtest.vim[473]..function RunTheTest[44]..Test_popup_atcursor_pos[37]..VerifyScreenDump line 58: See dump file difference: call term_dumpdiff("testdir/failed/Test_popupwin_atcursor_pos.dump", "testdir/dumps/Test_popupwin_atcursor_pos.dump"); difference in line 8: "|-@1|s+0#0000001#ffd7ff255|e|c|o|n|d|-+0#0000000#ffffff0@6|S+0#0000001#ffd7ff255|E|c|o|N|D|-+0#0000000#ffffff0@15|m+0#0000001#ffd7ff255|a|r|k|-+0#0000000#ffffff0@18| @14"; difference in line 9: "|-@1|#|-@16|&|-@4|c|o|n|c|e|a|l|e|d| @1>X|-@21| @14"
Run 2:
command line..script /home/pel/sb/vim/src/testdir/runtest.vim[507]..function RunTheTest[44]..Test_popup_atcursor_pos[37]..VerifyScreenDump line 58: See dump file difference: call term_dumpdiff("testdir/failed/Test_popupwin_atcursor_pos.dump", "testdir/dumps/Test_popupwin_atcursor_pos.dump"); difference in line 8: "|-@1|s+0#0000001#ffd7ff255|e|c|o|n|d|-+0#0000000#ffffff0@6|S+0#0000001#ffd7ff255|E|c|o|N|D|-+0#0000000#ffffff0@15|m+0#0000001#ffd7ff255|a|r|k|-+0#0000000#ffffff0@18| @14"; difference in line 9: "|-@1|#|-@16|&|-@4|c|o|n|c|e|a|l|e|d| @1>X|-@21| @14"
Run 3:
command line..script /home/pel/sb/vim/src/testdir/runtest.vim[507]..function RunTheTest[44]..Test_popup_atcursor_pos[37]..VerifyScreenDump line 58: See dump file difference: call term_dumpdiff("testdir/failed/Test_popupwin_atcursor_pos.dump", "testdir/dumps/Test_popupwin_atcursor_pos.dump"); difference in line 8: "|-@1|s+0#0000001#ffd7ff255|e|c|o|n|d|-+0#0000000#ffffff0@6|S+0#0000001#ffd7ff255|E|c|o|N|D|-+0#0000000#ffffff0@15|m+0#0000001#ffd7ff255|a|r|k|-+0#0000000#ffffff0@18| @14"; difference in line 9: "|-@1|#|-@16|&|-@4|c|o|n|c|e|a|l|e|d| @1>X|-@21| @14"
Flaky test failed too often, giving up
SKIPPED Test_popup_beval(): balloon_eval_term feature missing
Makefile:63: recipe for target 'test_popupwin' failed
make[1]: *** [test_popupwin] Error 1
make[1]: Leaving directory '/home/pel/sb/vim/src/testdir'
Makefile:2325: recipe for target 'test_popupwin' failed
make: *** [test_popupwin] Error 2

@codecov
Copy link

codecov bot commented Jul 3, 2021 •
edited

Codecov Report

Merging #8505 (0045638) into master (20cc528) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8505      +/-   ##
==========================================
- Coverage   90.02%   89.97%   -0.06%     
==========================================
  Files         149      149              
  Lines      167996   167349     -647     
==========================================
- Hits       151243   150572     -671     
- Misses      16753    16777      +24
Flag Coverage Δ
huge-clang-none 89.12% <ø> (+0.07%) ⬆️
huge-gcc-none 89.51% <ø> (+<0.01%) ⬆️
huge-gcc-testgui 88.11% <ø> (-0.01%) ⬇️
huge-gcc-unittests 2.49% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sound.c 96.00% <0.00%> (-1.00%) ⬇️
src/os_unix.c 71.16% <0.00%> (-0.96%) ⬇️
src/if_python.c 82.65% <0.00%> (-0.62%) ⬇️
src/gui.c 71.97% <0.00%> (-0.44%) ⬇️
src/syntax.c 86.58% <0.00%> (-0.43%) ⬇️
src/ops.c 95.58% <0.00%> (-0.42%) ⬇️
src/getchar.c 91.14% <0.00%> (-0.39%) ⬇️
src/if_cscope.c 82.06% <0.00%> (-0.37%) ⬇️
src/ui.c 83.01% <0.00%> (-0.36%) ⬇️
src/if_xcmdsrv.c 88.55% <0.00%> (-0.36%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20cc528...0045638. Read the comment docs.

@brammool brammool closed this in c60e959 Jul 3, 2021
janlazo added a commit to janlazo/neovim that referenced this pull request Jul 4, 2021
@janlazo
vim-patch:8.2.3085: JSONC files are not recognized
7e7a320 
Problem:    JSONC files are not recognized.
Solution:   Recognize .jsonc files. (Izhak Jakov, closes vim/vim#8500)
vim/vim@acbb4b5

N/A patches for version.c:

vim-patch:8.2.3081: cannot catch errors in a channel command

Problem:    Cannot catch errors in a channel command.
Solution:   Instead of skipping the error make it silent. (closes vim/vim#8477)
vim/vim@11a632d

vim-patch:8.2.3082: a channel command "echoerr" does not show anything

Problem:    A channel command "echoerr" does not show anything.
Solution:   Do not use silent errors when using an "echoerr" command.
            (closes vim/vim#8494)
vim/vim@b836f63

vim-patch:8.2.3094: Test_popup_atcursor_pos() fails without the conceal feature

Problem:    Test_popup_atcursor_pos() fails without the conceal feature.
Solution:   Add a check for the conceal feature. (Dominique Pellé,
            closes vim/vim#8505)
vim/vim@c60e959
janlazo added a commit to janlazo/neovim that referenced this pull request Jul 4, 2021
@janlazo
vim-patch:8.2.3085: JSONC files are not recognized
d706018 
Problem:    JSONC files are not recognized.
Solution:   Recognize .jsonc files. (Izhak Jakov, closes vim/vim#8500)
vim/vim@acbb4b5

N/A patches for version.c:

vim-patch:8.2.3081: cannot catch errors in a channel command

Problem:    Cannot catch errors in a channel command.
Solution:   Instead of skipping the error make it silent. (closes vim/vim#8477)
vim/vim@11a632d

vim-patch:8.2.3082: a channel command "echoerr" does not show anything

Problem:    A channel command "echoerr" does not show anything.
Solution:   Do not use silent errors when using an "echoerr" command.
            (closes vim/vim#8494)
vim/vim@b836f63

vim-patch:8.2.3094: Test_popup_atcursor_pos() fails without the conceal feature

Problem:    Test_popup_atcursor_pos() fails without the conceal feature.
Solution:   Add a check for the conceal feature. (Dominique Pellé,
            closes vim/vim#8505)
vim/vim@c60e959

vim-patch:8.2.3098: popup window test is flaky on MS-Windows with GUI

Problem:    Popup window test is flaky on MS-Windows with GUI.
Solution:   Skip the check in this situation.
vim/vim@999db23
chrisbra pushed a commit to chrisbra/vim that referenced this pull request Aug 30, 2021
@dpelle @chrisbra
patch 8.2.3094: Test_popup_atcursor_pos() fails without the conceal f…
602164f 
…eature

Problem:    Test_popup_atcursor_pos() fails without the conceal feature.
Solution:   Add a check for the conceal feature. (Dominique Pellé,
            closes vim#8505)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dpelle