Escape backslash in fish shell with shellescape() #8810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fish shell uses backslash as an escape character in single quotes, so the backslash must be escaped in order to produce a literal backslash. This change modifies the `shellescape()` function to escape backslash in Fish shell only. Note that Fish's backslash behavior is a bit odd in that it does what it thinks you mean. Only `'` really needs to be escaped (`echo '\''` prints `'`), so if the backslash precedes other characters, it will not be treated as an escape character (`echo '\a'` prints `\a`). However, all backslashes within single quotes can safely be escaped because two consecutive backslashes always produce a single literal backslash (`echo '\\a'` also prints `\a`).
Codecov Report
@@ Coverage Diff @@
## master #8810 +/- ##
===========================================
- Coverage 90.15% 2.46% -87.70%
===========================================
Files 151 149 -2
Lines 170762 165514 -5248
===========================================
- Hits 153949 4072 -149877
- Misses 16813 161442 +144629
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
chrisbra
pushed a commit
to chrisbra/vim
that referenced
this pull request
Aug 30, 2021
Problem: Escaping for fish shell does not work properly. Solution: Insert a backslash before a backslash. (Jason Cox, closes vim#8810)
lewis6991
pushed a commit
to lewis6991/neovim
that referenced
this pull request
Dec 12, 2021
Problem: Escaping for fish shell does not work properly. Solution: Insert a backslash before a backslash. (Jason Cox, closes vim/vim#8810) vim/vim@6e82351
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fish shell uses backslash as an escape character in single quotes, so
the backslash must be escaped in order to produce a literal backslash.
This change modifies the
shellescape()function to escape backslash inFish shell only.
Note that Fish's backslash behavior is a bit odd in that it does what it
thinks you mean. Only
'really needs to be escaped (echo '\''prints'), so if the backslash precedes other characters, it will not betreated as an escape character (
echo '\a'prints\a). However, allbackslashes within single quotes can safely be escaped because two
consecutive backslashes always produce a single literal backslash
(
echo '\\a'also prints\a).