Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ftplugin/spec.vim: Revert change dropping <SID> from SpecChangelog #9032

Merged
merged 1 commit into from Aug 20, 2023

Conversation

bcl
Copy link
Contributor

@bcl bcl commented Oct 21, 2021

Without this it will return an error when creating a new changelog
entry:
"Unknown function: SpecChangelog"

Without this it will return an error when creating a new changelog
entry:
"Unknown function: SpecChangelog"
@k-takata
Copy link
Member

Have you tried contacting the maintainer?

@brammool
Copy link
Contributor

@ignatenkobrain

@Jakuje
Copy link

Jakuje commented Nov 8, 2021

Verified that this solves my issue that I had last couple of weeks.

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #9032 (61d3ac3) into master (94e7d34) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 61d3ac3 differs from pull request most recent head a403350. Consider uploading reports for the commit a403350 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9032      +/-   ##
==========================================
- Coverage   90.09%   90.04%   -0.05%     
==========================================
  Files         151      147       -4     
  Lines      169614   167890    -1724     
==========================================
- Hits       152807   151175    -1632     
+ Misses      16807    16715      -92     
Flag Coverage Δ
huge-clang-none ?
huge-gcc-none 89.70% <ø> (+<0.01%) ⬆️
huge-gcc-testgui 88.35% <ø> (+0.01%) ⬆️
huge-gcc-unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/libvterm/src/unicode.c 70.83% <0.00%> (-18.75%) ⬇️
src/json.c 91.55% <0.00%> (-1.14%) ⬇️
src/help.c 89.76% <0.00%> (-1.08%) ⬇️
src/sound.c 96.03% <0.00%> (-1.00%) ⬇️
src/if_xcmdsrv.c 88.86% <0.00%> (-0.93%) ⬇️
src/strings.c 95.99% <0.00%> (-0.55%) ⬇️
src/beval.c 82.81% <0.00%> (-0.53%) ⬇️
src/message.c 88.19% <0.00%> (-0.44%) ⬇️
src/clipboard.c 83.35% <0.00%> (-0.44%) ⬇️
src/syntax.c 86.58% <0.00%> (-0.43%) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e7d34...a403350. Read the comment docs.

@zdohnal
Copy link
Contributor

zdohnal commented May 17, 2022

This PR is partially fixed in Vim project - it is only missing a downstream patch from Fedora
vim-7.4-releasestring-1318991.patch.txt

I've sent the fix to @ignatenkobrain via email as well.

@yegappan yegappan added this to the vim-9.1 milestone Aug 14, 2023
@chrisbra chrisbra merged commit a03380b into vim:master Aug 20, 2023
Konfekt pushed a commit to Konfekt/vim that referenced this pull request Aug 30, 2023
…log (vim#9032)

Without this it will return an error when creating a new changelog
entry:
"Unknown function: SpecChangelog"
chrisbra pushed a commit to chrisbra/vim that referenced this pull request Sep 22, 2023
…log (vim#9032)

Without this it will return an error when creating a new changelog
entry:
"Unknown function: SpecChangelog"
bitigchi pushed a commit to bitigchi/vim that referenced this pull request Dec 17, 2023
…log (vim#9032)

Without this it will return an error when creating a new changelog
entry:
"Unknown function: SpecChangelog"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants