Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell: only use nonomatch for csh like shells #9159

Closed
wants to merge 2 commits into from

Conversation

chrisbra
Copy link
Member

see #9153

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #9159 (c5c4b3f) into master (777175b) will decrease coverage by 0.00%.
The diff coverage is 40.00%.

❗ Current head c5c4b3f differs from pull request most recent head 9de12ad. Consider uploading reports for the commit 9de12ad to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9159      +/-   ##
==========================================
- Coverage   90.17%   90.16%   -0.01%     
==========================================
  Files         151      151              
  Lines      170656   170658       +2     
==========================================
- Hits       153881   153880       -1     
- Misses      16775    16778       +3     
Flag Coverage Δ
huge-clang-none 87.57% <40.00%> (+<0.01%) ⬆️
huge-gcc-none 89.71% <40.00%> (+<0.01%) ⬆️
huge-gcc-testgui 88.37% <40.00%> (+<0.01%) ⬆️
huge-gcc-unittests 2.45% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/os_unix.c 72.40% <40.00%> (-0.07%) ⬇️
src/netbeans.c 83.99% <0.00%> (-0.52%) ⬇️
src/misc1.c 89.19% <0.00%> (-0.21%) ⬇️
src/term.c 83.97% <0.00%> (-0.11%) ⬇️
src/viminfo.c 93.27% <0.00%> (-0.07%) ⬇️
src/gui_gtk_x11.c 63.99% <0.00%> (-0.05%) ⬇️
src/ex_getln.c 91.52% <0.00%> (+0.04%) ⬆️
src/search.c 92.78% <0.00%> (+0.09%) ⬆️
src/fileio.c 85.80% <0.00%> (+0.29%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777175b...9de12ad. Read the comment docs.

@brammool brammool closed this in 8b8d829 Nov 19, 2021
@chrisbra chrisbra deleted the nonomatch_gh9153 branch November 26, 2021 21:46
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Aug 19, 2022
Problem:    "$*" is expanded to "nonomatch".
Solution:   Only add "set nonomatch" when using a csh-like shell. (Christian
            Brabandt, closes vim/vim#9159, closes vim/vim#9153)
vim/vim@8b8d829

Cherry-pick a line from patch 8.2.0522.
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Aug 19, 2022
Problem:    "$*" is expanded to "nonomatch".
Solution:   Only add "set nonomatch" when using a csh-like shell. (Christian
            Brabandt, closes vim/vim#9159, closes vim/vim#9153)
vim/vim@8b8d829

Cherry-pick a line from patch 8.2.0522.
smjonas pushed a commit to smjonas/neovim that referenced this pull request Dec 31, 2022
Problem:    "$*" is expanded to "nonomatch".
Solution:   Only add "set nonomatch" when using a csh-like shell. (Christian
            Brabandt, closes vim/vim#9159, closes vim/vim#9153)
vim/vim@8b8d829

Cherry-pick a line from patch 8.2.0522.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant