Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Coverage on Windows (MinGW) #9750

Closed
wants to merge 2 commits into from

Conversation

ichizok
Copy link
Contributor

@ichizok ichizok commented Feb 11, 2022

We can set COVERAGE=yes on Windows MinGW build, so I propose that taking a test coverage on Windows CI.

And additionally some modifications on linux:

  • remove unnecessary success() expression in condition
  • add linux flag to codecov (to classify CI env)

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #9750 (9c6dc10) into master (29c70f6) will decrease coverage by 1.97%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9750      +/-   ##
==========================================
- Coverage   83.62%   81.64%   -1.98%     
==========================================
  Files         154      167      +13     
  Lines      174985   186299   +11314     
  Branches    39360    42017    +2657     
==========================================
+ Hits       146337   152112    +5775     
- Misses      16529    21718    +5189     
- Partials    12119    12469     +350     
Flag Coverage Δ
huge-clang-none 82.02% <ø> (ø)
huge-gcc-none 82.38% <ø> (+<0.01%) ⬆️
huge-gcc-testgui 80.84% <ø> (+<0.01%) ⬆️
huge-gcc-unittests 2.02% <ø> (ø)
linux 83.64% <ø> (?)
mingw-x64-HUGE 0.00% <ø> (?)
mingw-x64-HUGE-gui 76.87% <ø> (?)
windows 75.65% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sound.c 66.28% <0.00%> (-22.18%) ⬇️
src/if_python3.c 72.81% <0.00%> (-7.46%) ⬇️
src/locale.c 75.43% <0.00%> (-6.38%) ⬇️
src/terminal.c 78.02% <0.00%> (-5.42%) ⬇️
src/if_cscope.c 71.00% <0.00%> (-5.14%) ⬇️
src/mbyte.c 71.52% <0.00%> (-2.24%) ⬇️
src/main.c 83.63% <0.00%> (-1.42%) ⬇️
src/term.c 73.78% <0.00%> (-1.03%) ⬇️
src/if_lua.c 86.89% <0.00%> (-0.90%) ⬇️
src/ui.c 75.46% <0.00%> (-0.89%) ⬇️
... and 118 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c70f6...9c6dc10. Read the comment docs.

@k-takata k-takata added the CI Travis, AppVeyor, GHA, ... label Feb 11, 2022
@k-takata
Copy link
Member

This was also discussed in #6795.

@brammool
Copy link
Contributor

OK, I can include this. Please suggest further improvements if needed.

@brammool brammool closed this in 41ee5b1 Feb 12, 2022
@ichizok ichizok deleted the test/codecov-windows branch February 12, 2022 10:30
dundargoc added a commit to dundargoc/neovim that referenced this pull request Dec 16, 2023
Problem:    No coverage is measured on MS-Windows CI.
Solution:   Enable coverage on MS-Windows. (Ozaki Kiichi, closes vim/vim#9750)

vim/vim@41ee5b1

Co-authored-by: ichizok <gclient.gaap@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Travis, AppVeyor, GHA, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants