Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use better icons #9931

Closed
wants to merge 1 commit into from
Closed

use better icons #9931

wants to merge 1 commit into from

Conversation

chrisbra
Copy link
Member

BTW: I noticed the Gui version of Vim tries to load bitmaps/vim.ico from the runtime path.

This directory doesn't seem to be created anywhere, so I added it to the Installer and also created in the source archive, so that when no installer is used the file should be there as well.

I tested this and the installer uses the newer/better looking icons.

closes #9930

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #9931 (bb316fe) into master (20fb28b) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9931      +/-   ##
==========================================
- Coverage   81.89%   81.89%   -0.01%     
==========================================
  Files         167      167              
  Lines      187067   187067              
  Branches    42159    42159              
==========================================
- Hits       153198   153196       -2     
- Misses      21532    21534       +2     
  Partials    12337    12337              
Flag Coverage Δ
huge-clang-none 82.31% <ø> (-0.01%) ⬇️
huge-gcc-none 82.64% <ø> (+<0.01%) ⬆️
huge-gcc-testgui 81.10% <ø> (-0.01%) ⬇️
huge-gcc-unittests 2.01% <ø> (ø)
linux 83.88% <ø> (-0.01%) ⬇️
mingw-x64-HUGE 0.00% <ø> (ø)
mingw-x64-HUGE-gui 77.15% <ø> (+<0.01%) ⬆️
windows 75.93% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/message.c 81.27% <0.00%> (-0.24%) ⬇️
src/term.c 73.31% <0.00%> (-0.16%) ⬇️
src/netbeans.c 73.04% <0.00%> (-0.08%) ⬇️
src/libvterm/src/state.c 89.56% <0.00%> (-0.07%) ⬇️
src/window.c 87.91% <0.00%> (-0.07%) ⬇️
src/terminal.c 78.09% <0.00%> (-0.03%) ⬇️
src/os_win32.c 57.05% <0.00%> (ø)
src/gui_w32.c 35.04% <0.00%> (+0.03%) ⬆️
src/channel.c 83.81% <0.00%> (+0.04%) ⬆️
src/gui.c 74.08% <0.00%> (+0.09%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20fb28b...bb316fe. Read the comment docs.

@brammool brammool closed this in 176711f Mar 11, 2022
@chrisbra chrisbra deleted the gh_9930 branch April 23, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use better high resolution icons
1 participant