Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fe more resilient #55

Open
wants to merge 15 commits into
base: development
Choose a base branch
from
Open

Conversation

manuel-pross
Copy link
Collaborator

@manuel-pross manuel-pross commented Jun 20, 2024

Description

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore
  • ⏩ Revert

Related Issues and Pull Requests

Fixes: #(issue/ pr number)

Closes: #(issue/ pr number)

Depends on: #(issue/ pr number)

Mobile & Desktop Screenshots/Recordings (if applicable)

Mobile

Desktop

[optional] Design Documents or Screenshots

@manuel-pross manuel-pross changed the base branch from main to development June 20, 2024 11:22
Copy link
Collaborator

@jomunker jomunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far but I don't know if something is missing πŸ€” Did you go through all the code in web to check if it needs adjustments? Maybe we need more try catches or checkes here: web/src/app/api/[homepage]/route.ts

web/src/app/api/[homepage]/route.ts Show resolved Hide resolved
web/src/app/api/[homepage]/route.ts Outdated Show resolved Hide resolved
web/src/app/api/[homepage]/route.ts Show resolved Hide resolved
web/src/app/error/500/page.tsx Outdated Show resolved Hide resolved
web/src/app/layout.tsx Outdated Show resolved Hide resolved
web/src/app/layout.tsx Outdated Show resolved Hide resolved
web/src/app/layout.tsx Outdated Show resolved Hide resolved
web/src/app/layout.tsx Outdated Show resolved Hide resolved
web/src/app/layout.tsx Outdated Show resolved Hide resolved
web/src/helpers/getPageContent.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants