Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIMC-3908: Add the data visualisation tool to montagu #50

Merged
merged 4 commits into from Jun 1, 2020

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Jun 1, 2020

I've taken the opportunity to have us track "stable" for nginx, which will keep us more up to date.

Minimal changes in here to the conf in the end

@richfitz richfitz marked this pull request as ready for review June 1, 2020 13:06
Copy link
Contributor

@EmmaLRussell EmmaLRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea that this '/visualisation' route will eventually be present on all environments (so that's where we are eventually going to put the actual public-facing data vis tool)?
And the index.html is just what will be served until the script in vimc/montagu#167 is run, overwriting it with the report pathspecified there?
In which case we may be deploying this to prod before public viz is ready to go on prod? So maybe index.html should be a little more public-facing if there's a chance any external users might find their way to it, even if it's just to change 'Hello world' to 'Coming soon'?

@richfitz
Copy link
Member Author

richfitz commented Jun 1, 2020

Is the idea that this '/visualisation' route will eventually be present on all environments (so that's where we are eventually going to put the actual public-facing data vis tool)?

Yes, once the paper is published

And the index.html is just what will be served until the script in vimc/montagu#167 is run, overwriting it with the report pathspecified there?

This file primarily exists to make sure the directory does (though we could do that easily enough with an exec mkdir on vimc/montagu#167). For reasons unknown the /visualisation route gives a 403 to me, but I'm not that bothered by that.

In which case we may be deploying this to prod before public viz is ready to go on prod? So maybe index.html should be a little more public-facing if there's a chance any external users might find their way to it, even if it's just to change 'Hello world' to 'Coming soon'?

This should be fine to deploy to prod (having something we could not deploy would be problematic!)

@EmmaLRussell EmmaLRussell merged commit 76edb21 into master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants