vimc-6490: Save intermediate files out in qs format #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
===========================================
- Coverage 100.00% 99.75% -0.25%
===========================================
Files 19 19
Lines 2047 2063 +16
===========================================
+ Hits 2047 2058 +11
- Misses 0 5 +5
Continue to review full report at Codecov.
|
richfitz
approved these changes
Jun 22, 2022
| new_csv_file <- tempfile(fileext = ".csv") | ||
| write.csv(x = result$cal, file = new_csv_file, | ||
| row.names = FALSE) | ||
| new_csv_file <- tempfile(fileext = ".qs") |
|
Made a further update to support running stochastic upload with both qs files and csv files (for supporting re-uploading old outputs should we need to tear down annex at some point) |
weshinsley
approved these changes
Jun 24, 2022
R/stochastic_upload.R
Outdated
| if (type == "csv") { | ||
| read_stochastic_csv(file, is_cohort) | ||
| } else if (type == "qs") { | ||
| read <-read_stochastic_qs(file, is_cohort) |
There was a problem hiding this comment.
Is the read <- intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that read & writes are quicker
Also means we can remove some of the logic which checks row formatting when we read the file back in.
1 question about this - is the csv format useful? Will researchers ever get this file locally and look at it in excel? Or will they always load it into R to explore it? If the latter qs seems like a good choice, if the first maybe keeping the file as csv makes sense