Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Some generated SEO preview images don't have color #415

Closed
reobin opened this issue Oct 30, 2021 · 0 comments · Fixed by #416
Closed

bug: Some generated SEO preview images don't have color #415

reobin opened this issue Oct 30, 2021 · 0 comments · Fixed by #416
Assignees
@reobin
Labels
bug Something isn't working
Projects
Roadmap

Comments

@reobin
Copy link
Member

reobin commented Oct 30, 2021

Describe the bug

A preview image is generated at build time using puppeteer screenshots.

Some screenshots are taken before the colors are loaded onto the template.

Expected behavior

Wait for the colors to be loaded before taking the screenshot.
@reobin reobin added the bug Something isn't working label Oct 30, 2021
@reobin reobin self-assigned this Oct 30, 2021
@reobin reobin added this to Need research in Roadmap via automation Oct 30, 2021
@reobin reobin moved this from Need research to In progress in Roadmap Oct 30, 2021
@reobin reobin mentioned this issue Oct 30, 2021
Merged
14 tasks
Roadmap automation moved this from In progress to Ready for release Oct 30, 2021
@reobin reobin moved this from Ready for release to Released in Roadmap Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reobin reobin

Labels
bug Something isn't working
Projects
No open projects
Roadmap
Released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Wait for colors to be loaded before generating preview image vimcolorschemes/vimcolorschemes
1 participant
@reobin