Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wait for colors to be loaded before generating preview image #416

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

reobin
Copy link
Member

@reobin reobin commented Oct 30, 2021

Type of PR

  • Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Documentation update
  • Tests

Description

During preview image generation, wait for colors to be loaded on to the template before taking a screenshot with puppeteer.

Related issue

Closes #415

QA Instructions

  1. set GATSBY_ENABLE_GENERATE_PREVIEW_IMAGES to true in .env
  2. run npm run build
  3. open the ./public/previews directory
  4. check out the generated images

Added tests?

  • unit tests
  • E2E tests
  • no, because they aren't needed
  • no, because I need help

Added documentation?

  • JSDoc
  • docs.vimcolorschemes.com (./docs)
  • README
  • no

@vercel
Copy link

vercel bot commented Oct 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/reobin/vimcolorschemes/HTmDq911X75VpAik9nTjGXoFWJcB
✅ Preview: https://vimcolorschemes-git-fix-seo-preview-reobin.vercel.app

@reobin reobin merged commit e388cef into main Oct 30, 2021
@reobin reobin deleted the fix/seo-preview branch October 30, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Some generated SEO preview images don't have color
1 participant