Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitch Support #22

Open
pirm-in opened this issue Apr 14, 2020 · 2 comments
Open

Twitch Support #22

pirm-in opened this issue Apr 14, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers new provider

Comments

@pirm-in
Copy link

pirm-in commented Apr 14, 2020

Use the Twitch Embed Player to enable streaming videos, collections and channels on twitch.

There is an open PR on the plyr repository, but it's 2 years old and not quite finished.

I am considering using vime-js for an upcoming project, and would also be happy to help implementing stuff like this. A basic introduction in the documentation would be great though. ;)

@mihar-22
Copy link
Contributor

Hey @pirm-in sounds awesome, I was thinking of adding Twitch next as well. Videos and channels should be really easy but collections will need to wait for playlist support. I need to figure out how the playlists should function and look in the player, it'll probably be a plugin. I'm a little busy this week but as soon I get some time next week I'll get those docs up for you 👍

@mihar-22 mihar-22 added enhancement New feature or request new provider labels Apr 14, 2020
@mihar-22 mihar-22 added the v2 label Aug 11, 2020
@mihar-22 mihar-22 added good first issue Good for newcomers and removed v2 labels Oct 1, 2020
@mihar-22
Copy link
Contributor

mihar-22 commented Oct 1, 2020

There are instructions now in the contributing guide on how to add new providers, the example specifically walks through Twitch :)

https://github.com/vime-js/vime/blob/master/CONTRIBUTING.md#-providers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers new provider
Projects
None yet
Development

No branches or pull requests

2 participants