Add Options to EZ package #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachinagada
changed the title
dfinkel
reviewed
Jul 29, 2020
| func getDefaultOption() *dialsOptions { | ||
| return &dialsOptions{ | ||
| flagConfig: flag.DefaultFlagNameConfig(), | ||
| } |
There was a problem hiding this comment.
nit: Let's initialize watch to false explicitly.
ez/ez.go
Outdated
| return func(d *dialsOptions) { d.watch = true } | ||
| } | ||
|
|
||
| type decoderFactory func(string) dials.Decoder |
There was a problem hiding this comment.
This type should be exported with a docstring, since it's part of the public interface.
There was a problem hiding this comment.
Exported DecoderFactory and added a doc string
dfinkel
approved these changes
Jul 29, 2020
ez/ez.go
Outdated
| @@ -41,7 +42,8 @@ func WithWatchingConfigFile() Option { | |||
| return func(d *dialsOptions) { d.watch = true } | |||
| } | |||
|
|
|||
| type decoderFactory func(string) dials.Decoder | |||
| // DecoderFactory should return the appropriate decoder based on the config file name | |||
There was a problem hiding this comment.
nit: Let's extend his docstring slightly to say that the file path is passed as the string argument.
dfinkel
approved these changes
Jul 29, 2020
sergiosalvatore
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.