Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a warning when DateTime column has empty value #24

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

xinhus
Copy link
Contributor

@xinhus xinhus commented Jul 15, 2021

Dear reviewer,

When you have a DateTime column and the value is empty a warning was raised.

The code first checks the string at position 0 then check if is "empty".

On PHP version <= 7.4 A warning is raised if you try to access [0] of an "Uninitialized" string and $foo = '' is an "Uninitialized" string 🤷‍♂️ .

(I haven't check if this behavior still exists on PHP >=8.0).

The change is just a small change in the order of an existing code.

image

@muglug muglug merged commit 0870923 into vimeo:master Oct 6, 2021
@muglug
Copy link
Collaborator

muglug commented Oct 6, 2021

Thanks!

@xinhus xinhus deleted the fix-empty-date-column-warning branch July 13, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants