Fix a warning when DateTime column has empty value #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear reviewer,
When you have a DateTime column and the value is empty a warning was raised.
The code first checks the string at position 0 then check if is "empty".
On PHP version <= 7.4 A warning is raised if you try to access [0] of an "Uninitialized" string and
$foo = ''
is an "Uninitialized" string 🤷♂️ .(I haven't check if this behavior still exists on PHP >=8.0).
The change is just a small change in the order of an existing code.