Fix field support for CHARACTER SET & COLLATE #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two problems with
CHARACTER SET
&COLLATE
CHARACTER SET
orCOLLATE
would actually be set properly on the resulting table definitions.CHARACTER SET
&COLLATE
would be required for theCharacterColumn::getPhpCode
to include it in php code generationChanges:
src/Processor/CreateProcessor.php
The change togetTextDefinitionColumn
allows the values parsed from sql to be passed toColumn
generation functions.src/Schema/Column/CharacterColumn.php
generate each function arg individuallyAdded an integration test to the create table parser just for an easy add (
CreateProcessor::getDefinitionColumn
is private)cc @aaronm67