Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initializing player with the wrong ID makes it "uninitializable" again #190

Closed
cbmek opened this issue Dec 1, 2017 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@cbmek
Copy link

cbmek commented Dec 1, 2017

When you try to init player with wrong id, it of course fails:

var p = new Vimeo.Player('my-player', { width: 300, id: 'abc' });

but after this you are unable to init it again with the correct ID, since it will still try to use "abc" as ID, no matter what you will try to pass. Also it is unable to just use .loadVideo(), since player wasn't created, and player var is only a promise, not player.

Here is working example: https://jsfiddle.net/Ls4hm4sk/

And the screen with console log:

image

@luwes luwes added the bug Something isn't working label Feb 22, 2018
@luwes
Copy link
Contributor

luwes commented Mar 2, 2018

Duplicate of #166

@luwes luwes marked this as a duplicate of #166 Mar 2, 2018
@luwes luwes closed this as completed Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants