Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old URL still loading after catch #293

Closed
thiagosaife opened this issue Jul 20, 2018 · 2 comments
Closed

Old URL still loading after catch #293

thiagosaife opened this issue Jul 20, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@thiagosaife
Copy link

Expected Behavior

player.loadVideo(id) should restore to a valid state, after a catch statement was entered.

Actual Behavior

While using player.loadVideo(id) and the video doesn't exists, or any case that catch is entered, if one try another call to loadVideo function with a valid id, the player can't leave the catch state.
I could resolve this with a call to if (player) player.destroy() before every new Player call.

Steps to Reproduce

1 - Call player.loadVideo() with an invalid id
2 - Treat the error with a catch statement - One should see the error in console, a 404.
3 - Call player.loadVideo() again, this time with some valid id.
4 - One should see the same error over and over, making impossible to load a valid video.

@luwes luwes added the enhancement New feature or request label Oct 19, 2018
@rebecca-sich
Copy link
Contributor

Seems related to #166

@luwes
Copy link
Contributor

luwes commented Nov 1, 2018

Duplicate of #166

@luwes luwes marked this as a duplicate of #166 Nov 1, 2018
@luwes luwes closed this as completed Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants