-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
player.js and hidden from vimeo privacy settings not working #334
Comments
Thanks for reaching out @Ravenna - To ensure I can attempt to replicate your issue would you mind answering a couple questions,
|
We have the same issue, I assume. So, without access — to the Vimeo admin account — I presume we have the same issue. I’m on the iPhone now, but I’ll try to give you the information from memory. Maybe not 100% accurate — but it’ll give you the basic info you need to start pinpointing the problem. In our case the video embedded is at https://player.vimeo.com/video/ID and the player.js tries to access it by http(s)://vimeo.com/ID and that returns a 404. So there is probably some issue where the exact URL is important but the player.js presumes the later URL is valid in all cases, but I assume it’s not. The first URL shows privacy restrictions message and the second URL is a 404. By making the second URL accept all videos that is accepted by the first URL the player.js might remain unchanged I guess, if there is downsides of handling the different URL:s client side, so there might be alternative ways of solving the issue, whatever suits you best I guess. — My assumptions might be wrong, but hopefully it can give you some angels to handle the issue. |
@jonascarlbaum there is nothing we can do about that. you say you have no control over the customers videos and they chose to make it private. it's normal that you can't embed it on your website then because the customer has configured it that way. |
@Ravenna can you check the Embed it like so <div id="made-in-ny"></div>
<script src="https://player.vimeo.com/api/player.js"></script>
<script>
var options = {
url: 'https://vimeo.com/293438045/463ebf7bcf'
};
var player = new Vimeo.Player('made-in-ny', options);
player.setVolume(0);
player.on('play', function() {
console.log('played the video!');
});
</script> |
Well, I mean I haven’t got the credentials to look at how they’ve set up their privacy settings. We are working on their site and I mean that the affected video shows as embedded IFrame on production, not on stage, so I just wrote that to give you the info that implies that privacy setup — without the need to ask for credentials to look that up in the admin interface. The private videos are the ones they would like on their production intranet, i presume — that is no issue to me. We are actually using plyr (https://github.com/sampotts/plyr) that uses player.js — to ease the abstraction level when the customer want the opportunity of using multiple video providers. I need to look closer at this tomorrow. I can of course ask the customer for the credentials to look things up or ask them to give me a screenshot of the privacy settings. My initial look into the issue was that there might be a issue in player.js, but it might as well be how player.js is used by plyr. When reading this thread again I understand that it was unclear what I mean. We are using plyr that uses player.js, to fill a div with the video embed code you see fit — public or private videos — and that doesn’t work on all videos, even on the site where the restricted video plays when embedded using iframe directly. So the site is the trusted domain the video is aimed at. All Vimeo videos have played well so far with our setup, 1.5 years, so assumed that there is something on the Vimeo side that have changed, or the privacy settings is new for the customer, and that means the current setup is using player.js in the wrong way. — I’m sorry for the confusion, and I realize that the issue could be on the plyr side as well — or our side, but I didn’t find anything in our code at first glimpse. — I could provide more error trace tomorrow if I can trace the error to your code then. |
Thanks @jonascarlbaum I will give this a shot later today. |
I have the same issue. Making a course and want the videos to only be available via my website. When I hide from Vimeo and allow on my specific site I get this error. Failed to load resource: the server responded with a status of 404 (Not Found)
player.es.js:796 Uncaught (in promise) Error: “https://vimeo.com/297488944” was not found.
at XMLHttpRequest.xhr.onload (player.es.js:796) @luwes help? This renders hosting on Vimeo useless for private course. It was not like this a month ago. |
@ahmadawais this error is the exact one I talked about (from memory) — except the |
@ahmadawais I guess the https://player.vimeo.com/video/297488944 |
I was able to get it working. I have to chose |
Thanks for reporting guys. We're aware of the different behavior w/ direct iframe embeds compared to a player.js initialization via When the In the mean time you could use the
Notice the |
Great, so it’s solvable for me by instructing the customer to change some settings in Vimeo. But still it should work for us in the first place without workarounds? |
Ah, answered @ahmadawais comment. Seems I need to get access to their account to test and advice them correctly. For example, we let them put in an It’s great to hear that you are working on a solution. 👍 |
This should be resolved. Please let me know if you see otherwise or have any questions. Thanks. whitelisted domain: https://codepen.io/luwes/pen/mzZgZg |
It seems that videos protected by private link (without domain protection) don't work. Here's the code: Link to the video: https://vimeo.com/320269670/eced817cc0 |
Expected Behavior
Video embeds successfully
Actual Behavior
Video embeds but vimeo js fails to load the video
Steps to Reproduce
embed a video that is hidden from vimeo and restricted to specific domains using the player.js
I have a business account, paying more than $500 a year and would like to be able to use the player js in a meaningful way. I am loading videos via the player.js. I want the videos hidden from vimeo and embeddable only on my domain as the videos are my IP.
Please advise ASAP
The text was updated successfully, but these errors were encountered: