Improve check for empty array

vimeo · Jul 15, 2020 · 06ee1b7 · 06ee1b7
1 parent 0ab163f
commit 06ee1b7
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 8 deletions.
diff --git a/src/Psalm/Internal/Stubs/CoreGenericFunctions.phpstub b/src/Psalm/Internal/Stubs/CoreGenericFunctions.phpstub
@@ -132,10 +132,11 @@ function array_flip(array $arr)
 
 /**
  * @psalm-template TKey as array-key
+ * @psalm-template TArray as array<TKey, mixed>
  *
- * @param array<TKey, mixed> $arr
+ * @param TArray $arr
  *
- * @return (TKey is empty ? null : ($arr is non-empty-array ? TKey : TKey|null))
+ * @return (TArray is array<empty, empty> ? null : (TArray is non-empty-array ? TKey : TKey|null))
  * @psalm-pure
  */
 function key($arr)
@@ -144,10 +145,11 @@ function key($arr)
 
 /**
  * @psalm-template TKey as array-key
+ * @psalm-template TArray as array<TKey, mixed>
  *
- * @param array<TKey, mixed> $arr
+ * @param TArray $arr
  *
- * @return (TKey is empty ? null : ($arr is non-empty-array ? TKey : TKey|null))
+ * @return (TArray is array<empty, empty> ? null : (TArray is non-empty-array ? TKey : TKey|null))
  * @psalm-pure
  */
 function array_key_first($arr)
@@ -156,10 +158,11 @@ function array_key_first($arr)
 
 /**
  * @psalm-template TKey as array-key
+ * @psalm-template TArray as array<TKey, mixed>
  *
- * @param array<TKey, mixed> $arr
+ * @param TArray $arr
  *
- * @return (TKey is empty ? null : ($arr is non-empty-array ? TKey : TKey|null))
+ * @return (TArray is array<empty, empty> ? null : (TArray is non-empty-array ? TKey : TKey|null))
  * @psalm-pure
  */
 function array_key_last($arr)

diff --git a/tests/ArrayFunctionCallTest.php b/tests/ArrayFunctionCallTest.php
@@ -770,6 +770,16 @@ function mapdef(string $_a, int $_b = 0): string {
                     '$b' => 'string',
                 ],
             ],
+            'keyNonEmptyArray' => [
+                '<?php
+                    /**
+                     * @param non-empty-array $arr
+                     * @return array-key
+                     */
+                    function foo(array $arr) {
+                        return key($arr);
+                    }',
+            ],
             'arrayKeyFirst' => [
                 '<?php
                     /** @return array<string, int> */

diff --git a/tests/TypeReconciliation/EmptyTest.php b/tests/TypeReconciliation/EmptyTest.php
@@ -244,7 +244,7 @@ function foo(array $n): void {
                         }
                     }',
             ],
-            'SKIPPED-unsetChangesComplicatedArrayEmptiness' => [
+            'unsetChangesComplicatedArrayEmptiness' => [
                 '<?php
                     function contains(array $data, array $needle): bool {
                         if (empty($data) || empty($needle)) {
@@ -253,7 +253,6 @@ function contains(array $data, array $needle): bool {
                         $stack = [];
 
                         while (!empty($needle)) {
-                            /** @psalm-trace $key */
                             $key = key($needle);
                             $val = $needle[$key];
                             unset($needle[$key]);