Fix #2789 - Numeric should not be a reserved class name

vimeo · Feb 12, 2020 · 07a53f6 · 07a53f6
1 parent a23dd9f
commit 07a53f6
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 3 deletions.
diff --git a/src/Psalm/Internal/Analyzer/ClassAnalyzer.php b/src/Psalm/Internal/Analyzer/ClassAnalyzer.php
@@ -119,7 +119,7 @@ public function analyze(
 
         if ($class->name
             && (preg_match(
-                '/(^|\\\)(int|float|bool|string|void|null|false|true|object|numeric|mixed)$/i',
+                '/(^|\\\)(int|float|bool|string|void|null|false|true|object|mixed)$/i',
                 $fq_class_name
             ) || strtolower($fq_class_name) === 'resource')
         ) {

diff --git a/src/Psalm/Internal/Analyzer/ClassLikeAnalyzer.php b/src/Psalm/Internal/Analyzer/ClassLikeAnalyzer.php
@@ -240,7 +240,7 @@ public static function checkFullyQualifiedClassLikeName(
         }
 
         if (preg_match(
-            '/(^|\\\)(int|float|bool|string|void|null|false|true|object|numeric|mixed)$/i',
+            '/(^|\\\)(int|float|bool|string|void|null|false|true|object|mixed)$/i',
             $fq_class_name
         ) || strtolower($fq_class_name) === 'resource'
         ) {

diff --git a/src/Psalm/Type.php b/src/Psalm/Type.php
@@ -206,7 +206,6 @@ private static function fixScalarTerms(
             case 'iterable':
             case 'array':
             case 'object':
-            case 'numeric':
             case 'true':
             case 'false':
             case 'null':

diff --git a/tests/ClassTest.php b/tests/ClassTest.php
@@ -466,6 +466,31 @@ class OldAChild extends OldA {}
                     action(new OldA());
                     action(new OldAChild());'
             ],
+            'resourceAndNumericSoftlyReserved' => [
+                '<?php
+                    namespace Foo {
+                        class Resource {}
+                        class Numeric {}
+                    }
+
+                    namespace Bar {
+                        use \Foo\Resource;
+                        use \Foo\Numeric;
+
+                        new \Foo\Resource();
+                        new \Foo\Numeric();
+
+                        new Resource();
+                        new Numeric();
+
+                        /**
+                         * @param  Resource $r
+                         * @param  Numeric  $n
+                         * @return void
+                         */
+                        function foo(Resource $r, Numeric $n) : void {}
+                    }'
+            ],
         ];
     }