Don’t convert trait self to trait name

vimeo · Jun 26, 2019 · 372a512 · 372a512
1 parent c66a106
commit 372a512
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/Psalm/Internal/Visitor/ReflectorVisitor.php b/src/Psalm/Internal/Visitor/ReflectorVisitor.php
@@ -2157,7 +2157,7 @@ private function registerFunctionLike(PhpParser\Node\FunctionLike $stmt, $fake_m
                 $docblock_info->params,
                 $stmt,
                 $fake_method,
-                $class_storage ? $class_storage->name : null
+                $class_storage && !$class_storage->is_trait ? $class_storage->name : null
             );
         }
 
@@ -2279,7 +2279,7 @@ function (FunctionLikeParameter $p) {
                         $this->aliases,
                         $this->function_template_types + $this->class_template_types,
                         $this->type_aliases,
-                        $class_storage ? $class_storage->name : null
+                        $class_storage && !$class_storage->is_trait ? $class_storage->name : null
                     );
 
                     $storage->return_type = Type::parseTokens(

diff --git a/tests/TraitTest.php b/tests/TraitTest.php
@@ -854,6 +854,19 @@ class Foo {
                     $f1 = new Foo();
                     $f2 = (new Foo())->bar($f1);',
             ],
+            'traitSelfDocblockReturn' => [
+                '<?php
+                    trait T {
+                        /** @return self */
+                        public function getSelf() {
+                            return $this;
+                        }
+                    }
+
+                    class C {
+                        use T;
+                    }'
+            ],
         ];
     }