Merge pull request #6684 from orklah/empty-reconciliation

improve empty/falsy reconciliation
vimeo · Oct 20, 2021 · 3d9f973 · 3d9f973
2 parents 541a1ed + cf8e443
commit 3d9f973
Show file tree

Hide file tree

Showing 6 changed files with 347 additions and 428 deletions.
diff --git a/src/Psalm/Internal/LanguageServer/ProtocolStreamReader.php b/src/Psalm/Internal/LanguageServer/ProtocolStreamReader.php
@@ -116,7 +116,10 @@ private function readMessages(string $buffer) : int
                         if ($msg) {
                             ++$emitted_messages;
                             $this->emit('message', [$msg]);
-                            /** @psalm-suppress DocblockTypeContradiction */
+                            /**
+                             * @psalm-suppress DocblockTypeContradiction
+                             * @psalm-suppress ParadoxicalCondition
+                             */
                             if (!$this->is_accepting_new_requests) {
                                 // If we fork, don't read any bytes in the input buffer from the worker process.
                                 $this->emitClose();