Merge pull request #10659 from weirdan/7395-suppress-UndefinedClass-i…

…n-whatever_exists
vimeo · Feb 5, 2024 · 4621705 · 4621705
2 parents f40e23f + b822c33
commit 4621705
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 3 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php
@@ -191,7 +191,7 @@ public static function analyze(
 
             $toggled_class_exists = false;
 
-            if ($method_id === 'class_exists'
+            if (in_array($method_id, ['class_exists', 'interface_exists', 'enum_exists', 'trait_exists'], true)
                 && $argument_offset === 0
                 && !$context->inside_class_exists
             ) {

diff --git a/tests/FunctionCallTest.php b/tests/FunctionCallTest.php
@@ -777,8 +777,31 @@ function exploder(string $d, string $s) : array {
                     }',
             ],
             'allowPossiblyUndefinedClassInClassExists' => [
-                'code' => '<?php
-                    if (class_exists(Foo::class)) {}',
+                'code' => <<<'PHP'
+                    <?php
+                    if (class_exists(Foo::class)) {}
+                    PHP,
+            ],
+            'allowPossiblyUndefinedClassInInterfaceExists' => [
+                'code' => <<<'PHP'
+                    <?php
+                    if (interface_exists(Foo::class)) {}
+                    PHP,
+            ],
+            'allowPossiblyUndefinedClassInTraitExists' => [
+                'code' => <<<'PHP'
+                    <?php
+                    if (trait_exists(Foo::class)) {}
+                    PHP,
+            ],
+            'allowPossiblyUndefinedClassInEnumExists' => [
+                'code' => <<<'PHP'
+                    <?php
+                    if (enum_exists(Foo::class)) {}
+                    PHP,
+                'assertions' => [],
+                'ignored_issues' => [],
+                'php_version' => '8.1',
             ],
             'allowConstructorAfterClassExists' => [
                 'code' => '<?php